Fixes #1482, removed unsafe double RLock

intelsdi-x · Feb 17, 2017 · 20f15b2 · 20f15b2
1 parent 85079bc
commit 20f15b2
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/control/strategy/pool.go b/control/strategy/pool.go
@@ -361,10 +361,8 @@ func (p *pool) SubscriptionCount() int {
 }
 
 // SelectAP selects an available plugin from the pool
+// the method is not thread safe, it should be protected outside of the body
 func (p *pool) SelectAP(taskID string, config map[string]ctypes.ConfigValue) (AvailablePlugin, serror.SnapError) {
-	p.RLock()
-	defer p.RUnlock()
-
 	aps := p.plugins.Values()
 
 	var id string