RUN: enable --show-output when executing tests #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmericp
force-pushed
the
tests-always-show-stdout
branch
2 times, most recently
from
5e4d090 to
bc1d021
Compare
src/test/kotlin/org/rust/cargo/runconfig/CargoTestRunStateTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/rust/cargo/runconfig/CargoTestRunStateTest.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/rust/cargo/runconfig/CargoTestRunStateTest.kt
Outdated
Show resolved
Hide resolved
emmericp
force-pushed
the
tests-always-show-stdout
branch
from
bc1d021 to
d18c7e4
Compare
emmericp
force-pushed
the
tests-always-show-stdout
branch
from
d18c7e4 to
c6767e8
Compare
Show output of successful tests when running on a rust version that supports doing so (1.39.0+)
emmericp
force-pushed
the
tests-always-show-stdout
branch
from
c6767e8 to
50cc65d
Compare
|
The feature has been merged and is available in Rust 1.39 nightly builds with a build date of 28-08-2019 or later. I've updated this PR accordingly and fixed the merge conflict |
emmericp
changed the title
Undin
reviewed
Aug 30, 2019
|
|
||
| private fun checkShowOutputSupport(ver: RustcVersion?): Boolean { | ||
| if (ver == null) return false | ||
| // --show-output is supported since 1.39.0-nightly/dev with a build date later than 2019-08-27 |
There was a problem hiding this comment.
Can we check that this flag is supported without version checking? Like we do with some other flags
There was a problem hiding this comment.
I think no. The --show-output is only mentioned in cargo test -- --help output, but this command may trigger compilation.
There was a problem hiding this comment.
i don't think it's possible to detect this without compiling tests as it's a feature in libtest that's only in the resulting test binary
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 30, 2019
4139: RUN: enable --show-output when executing tests r=mchernyavsky a=emmericp Fixes #3994 This requires this patch for rust (hopefully in 1.38?): rust-lang/rust#62600 This is work in progress because it doesn't work yet, I'm looking for some help here: The problem is you can't run `rustVersion()` in the UI thread and I'd really like to have this behavior as default if the compiler is new enough. What's the best way to achieve this? Fallback would be to make this an option for the run configuration, but that would be a little bit annoying since virtually everyone would want to enable this? Edit: changed the code to hardcode 1.38 as Rust version passed to `patchArgs` because I'm using this branch ;) Looking for a good way to get the Rust version here. <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt :) --> Co-authored-by: Paul Emmerich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3994
This requires this patch for rust (hopefully in 1.38?): rust-lang/rust#62600
This is work in progress because it doesn't work yet, I'm looking for some help here:
The problem is you can't run
rustVersion()in the UI thread and I'd really like to have this behavior as default if the compiler is new enough.What's the best way to achieve this? Fallback would be to make this an option for the run configuration, but that would be a little bit annoying since virtually everyone would want to enable this?
Edit: changed the code to hardcode 1.38 as Rust version passed to
patchArgsbecause I'm using this branch ;) Looking for a good way to get the Rust version here.