Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

[GPIOPins] Fail to close GPIOPins #311

Closed
cuiyanx opened this issue Oct 20, 2016 · 4 comments
Closed

[GPIOPins] Fail to close GPIOPins #311

cuiyanx opened this issue Oct 20, 2016 · 4 comments
Milestone

Comments

@cuiyanx
Copy link
Contributor

cuiyanx commented Oct 20, 2016

After closed the GPIO pin, I can read and write this pin. It is different to description of GPIOPin.close function.

GPIOPin.close
void close();
Free up resources associated with the pin. The onchange function for this pin will no longer be called, and the object should not be used for reading and writing anymore.

@grgustaf
Copy link
Contributor

Technically, it doesn't say that won't work. It says you shouldn't do that. (I.e. it might not work in the future.) But yeah, probably we should force it to not work so people don't rely on this behavior.

@cuiyanx
Copy link
Contributor Author

cuiyanx commented Oct 27, 2016

So, I think it is better method of forcing it to not work.

@grgustaf grgustaf self-assigned this Dec 6, 2016
@grgustaf grgustaf added this to the 0.2 milestone Dec 6, 2016
@grgustaf
Copy link
Contributor

FWIW I see onchange does get disabled, but you're right, read/write don't.

grgustaf added a commit to grgustaf/zephyr.js-1 that referenced this issue Dec 23, 2016
grgustaf added a commit to grgustaf/zephyr.js-1 that referenced this issue Dec 23, 2016
@grgustaf
Copy link
Contributor

This should be fixed by #577.

@grgustaf grgustaf added the fixed label Dec 23, 2016
@cuiyanx cuiyanx closed this as completed Dec 26, 2016
grgustaf added a commit that referenced this issue Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants