support alibi embedding #24
Conversation
src/layers/alibi_embedding.cpp
Outdated
There was a problem hiding this comment.
Look like the codeis not formatted, pls format it.
There was a problem hiding this comment.
Code has been formatted
|
Please use Camel case to rename variables and functions. |
src/layers/alibi_embedding.h
Outdated
| void alibiGetBias(const int headIdx, const int seqLen, float *bias_matrx); | ||
|
|
||
| private: | ||
| static bool initialized; |
There was a problem hiding this comment.
What's the meaning of this bool var? Nothing will be shared between objects.
There was a problem hiding this comment.
This variable is used to determine whether the distance matrix has been initialized or not. And In this pr, 1. If alibiGetBias function is called directly without the initialization judgment, an error will occur. 2. The distance matrix can be reused w/ single instance.
There was a problem hiding this comment.
All the functions are not static, so they can't be called without instantiating a class. And you will initialize it in the constructor. Will you offer a constructor method without initialization or a static method?
No description provided.