This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Dockerfile: Redefine SWUPD_UPDATE_ARG in all build stages. #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ARG instruction goes out of scope at the end of the build stage where it was defined. To use an arg in multiple stages, each stage must include the ARG instruction. Refer to: https://github.com/docker/cli/blob/master/docs/reference/builder.md#understand-how-arg-and-from-interact FIXES: intel#382
mythi
approved these changes
Aug 16, 2019
Yes. This script uses = suffix( |
|
@avalluri how about updating release-0.5 branch too? |
|
Mikko Ylinen <[email protected]> writes:
@avalluri how about updating release-0.5 branch too?
`update-clear-linux-base.sh` run is also needed but that should
probably wait until the `swupd` error 255 is fixed.
Yes, this needs to be backported.
@avalluri: are you tracking that?
|
|
Amarnath Valluri <[email protected]> writes:
Can you take the AR to do this?
Do we need a new release with this fix?
No, the next regular 0.5.x update will have it.
|
|
Done. New release v0.5.2 with change is published. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ARG instruction goes out of scope at the end of the build stage where it was
defined. To use an arg in multiple stages, each stage must include the ARG
instruction.
Refer to:
https://github.com/docker/cli/blob/master/docs/reference/builder.md#understand-how-arg-and-from-interact
FIXES: #382