DeviceManager/LVM: Added unit tests

Used file backed loop device to mimic an logical volume group, so sudo/root user
permission is required to run device manager unit tests.

Gopkg.toml

@@ -44,6 +44,10 @@
   name = "github.com/kubernetes-csi/csi-test"
   version = "2.3.0"
 
+[[constraint]]
+  name = "gopkg.in/freddierice/go-losetup.v1"
+  branch = "v1"
+
 # We have to select the right version by name because of the "kubernetes-" prefix, dep doesn't
 # recognize these as normal releases. Upstream is considering to change the tagging,
 # see https://github.com/kubernetes/kubernetes/issues/72638.

pkg/pmem-device-manager/pmd-lvm.go

@@ -60,6 +60,10 @@ func NewPmemDeviceManagerLVM() (PmemDeviceManager, error) {
 	}
 	ctx.Free()
 
+	return NewPmemDeviceManagerLVMForVGs(volumeGroups)
+}
+
+func NewPmemDeviceManagerLVMForVGs(volumeGroups []string) (PmemDeviceManager, error) {
 	devices, err := listDevices(volumeGroups...)
 	if err != nil {
 		return nil, err

pkg/pmem-device-manager/pmd-lvm_test.go

@@ -0,0 +1,339 @@
+/*
+Copyright 2019  Intel Corporation.
+
+SPDX-License-Identifier: Apache-2.0
+*/
+package pmdmanager
+
+import (
+	"errors"
+	"fmt"
+	"io/ioutil"
+	"math/rand"
+	"os"
+	"testing"
+
+	pmemexec "github.com/intel/pmem-csi/pkg/pmem-exec"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	losetup "gopkg.in/freddierice/go-losetup.v1"
+)
+
+const (
+	vgname = "test-group"
+	nsmode = "fsdax"
+	vgsize = uint64(1) * 1024 * 1024 * 1024 // 1Gb
+
+	ModeLVM    = "lvm"
+	ModeDirect = "direct"
+)
+
+var mode string = ModeLVM
+
+func TestMain(m *testing.M) {
+	RegisterFailHandler(Fail)
+
+	if deviceMode := os.Getenv("TEST_DEVICEMODE"); deviceMode == ModeDirect {
+		mode = deviceMode
+	}
+
+	os.Exit(m.Run())
+}
+
+func TestPmdLVM(t *testing.T) {
+	RunSpecs(t, fmt.Sprintf("PMEM Device manager Suite(Mode: %s)", mode))
+}
+
+var _ = Describe("DeviceManager", func() {
+	var dm PmemDeviceManager
+	var vg *testVGS
+	var cleanupList map[string]bool = map[string]bool{}
+	var err error
+
+	BeforeEach(func() {
+		precheck()
+
+		if mode == ModeLVM {
+			vg, err = createTestVGS(vgname, nsmode, vgsize)
+			Expect(err).Should(BeNil(), "Failed to create volume group")
+
+			dm, err = NewPmemDeviceManagerLVMForVGs([]string{vg.name})
+		} else {
+			dm, err = NewPmemDeviceManagerNdctl()
+		}
+		Expect(err).Should(BeNil(), "Failed to create LVM device manager")
+
+	})
+
+	AfterEach(func() {
+		for devName, ok := range cleanupList {
+			if !ok {
+				continue
+			}
+			By("Cleaning up device: " + devName)
+			dm.DeleteDevice(devName, false)
+		}
+		if mode == ModeLVM {
+			err := vg.Clean()
+			Expect(err).Should(BeNil(), "Failed to create LVM device manager")
+		}
+	})
+
+	//Context("LVM", func() {
+	It("Should create a new device", func() {
+		name := "test-dev"
+		size := uint64(2) * 1024 * 1024 // 2Mb
+		err := dm.CreateDevice(name, size, nsmode)
+		Expect(err).Should(BeNil(), "Failed to create new device")
+
+		cleanupList[name] = true
+
+		dev, err := dm.GetDevice(name)
+		Expect(err).Should(BeNil(), "Failed to retrieve device info")
+		Expect(dev.VolumeId).Should(Equal(name), "Name mismatch")
+		Expect(dev.Size >= size).Should(BeTrue(), "Size mismatch")
+		Expect(dev.Path).ShouldNot(BeNil(), "Null device path")
+	})
+
+	It("Should fail to retrieve non-existent device", func() {
+		dev, err := dm.GetDevice("unknown")
+		Expect(err).ShouldNot(BeNil(), "Error expected")
+		Expect(errors.Is(err, ErrDeviceNotFound)).Should(BeTrue(), "expected error is device not found error")
+		Expect(dev).Should(BeNil(), "returned device should be nil")
+	})
+
+	It("Should list devices", func() {
+		max_devices := 4
+		max_deletes := 2
+		sizes := map[string]uint64{}
+
+		list, err := dm.ListDevices()
+		Expect(err).Should(BeNil(), "Failed to list devices")
+		Expect(len(list)).Should(BeEquivalentTo(0), "count mismatch")
+
+		for i := 1; i <= max_devices; i++ {
+			name := fmt.Sprintf("list-dev-%d", i)
+			sizes[name] = rand.Uint64() % 16 * 1024 * 1024
+			err := dm.CreateDevice(name, sizes[name], nsmode)
+			Expect(err).Should(BeNil(), "Failed to create new device")
+			cleanupList[name] = true
+		}
+		list, err = dm.ListDevices()
+		Expect(err).Should(BeNil(), "Failed to list devices")
+		Expect(len(list)).Should(BeEquivalentTo(max_devices), "count mismatch")
+		for _, dev := range list {
+			size, ok := sizes[dev.VolumeId]
+			Expect(ok).Should(BeTrue(), "Unexpected device name:"+dev.VolumeId)
+			Expect(dev.Size >= size).Should(BeTrue(), "Device size mismatch")
+		}
+
+		for i := 1; i <= max_deletes; i++ {
+			name := fmt.Sprintf("list-dev-%d", i)
+			delete(sizes, name)
+			err = dm.DeleteDevice(name, false)
+			Expect(err).Should(BeNil(), "Error while deleting device '"+name+"'")
+			cleanupList[name] = false
+		}
+
+		// List device after deleting a device
+		list, err = dm.ListDevices()
+		Expect(err).Should(BeNil(), "Failed to list devices")
+		Expect(len(list)).Should(BeEquivalentTo(max_devices-max_deletes), "count mismatch")
+		for _, dev := range list {
+			size, ok := sizes[dev.VolumeId]
+			Expect(ok).Should(BeTrue(), "Unexpected device name:"+dev.VolumeId)
+			Expect(dev.Size >= size).Should(BeTrue(), "Device size mismatch")
+		}
+	})
+
+	It("Should delete devices", func() {
+		name := "delete-dev"
+		size := uint64(2) * 1024 * 1024 // 2Mb
+		err := dm.CreateDevice(name, size, nsmode)
+		Expect(err).Should(BeNil(), "Failed to create new device")
+		cleanupList[name] = true
+
+		dev, err := dm.GetDevice(name)
+		Expect(err).Should(BeNil(), "Failed to retrieve device info")
+		Expect(dev.VolumeId).Should(Equal(name), "Name mismatch")
+		Expect(dev.Size >= size).Should(BeTrue(), "Size mismatch")
+		Expect(dev.Path).ShouldNot(BeNil(), "Null device path")
+
+		mountPath, err := mountDevice(dev)
+		Expect(err).Should(BeNil(), "Failed to create mount path: %s", mountPath)
+
+		defer unmount(mountPath)
+
+		// Delete should fail as the device is in use
+		err = dm.DeleteDevice(name, true)
+		Expect(err).ShouldNot(BeNil(), "Error expected when deleting device in use: %s", dev.VolumeId)
+		Expect(errors.Is(err, ErrDeviceInUse)).Should(BeTrue(), "Expected device busy error: %s", dev.VolumeId)
+		cleanupList[name] = false
+
+		err = unmount(mountPath)
+		Expect(err).Should(BeNil(), "Failed to unmount the device: %s", dev.VolumeId)
+
+		// Delete should succeed
+		err = dm.DeleteDevice(name, true)
+		Expect(err).Should(BeNil(), "Failed to delete device")
+
+		dev, err = dm.GetDevice(name)
+		Expect(err).ShouldNot(BeNil(), "GetDevice() should fail on deleted device")
+		Expect(errors.Is(err, ErrDeviceNotFound)).Should(BeTrue(), "expected error is os.ErrNotExist")
+		Expect(dev).Should(BeNil(), "returned device should be nil")
+
+		// Delete call should not return any error on non-existing device
+		err = dm.DeleteDevice(name, true)
+		Expect(err).Should(BeNil(), "DeleteDevice() is not idempotent")
+	})
+	//	})
+})
+
+func precheck() {
+	if os.Geteuid() != 0 {
+		Skip("Required root used privilege to these tests", 1)
+	}
+
+	info, err := os.Stat(losetup.LoopControlPath)
+	if err != nil {
+		Skip(fmt.Sprintf("Stat(%s) failure: %s", losetup.LoopControlPath, err.Error()), 1)
+	}
+	if isDev := info.Mode()&os.ModeDevice != 0; !isDev {
+		Skip(fmt.Sprintf("%s is not a loop device file", losetup.LoopControlPath), 1)
+	}
+}
+
+type testVGS struct {
+	name       string
+	loopDev    losetup.Device
+	backedFile string
+}
+
+func createTestVGS(vgname, nsmode string, size uint64) (*testVGS, error) {
+	var err error
+	var file *os.File
+	var dev losetup.Device
+	var out string
+
+	By("Creating temporary file")
+	if file, err = ioutil.TempFile("", "test-lvm-dev"); err != nil {
+		By("Cleaning temporary file")
+		return nil, fmt.Errorf("Fail to create temporary file : %s", err.Error())
+	}
+
+	defer func() {
+		if err != nil && file != nil {
+			os.Remove(file.Name())
+		}
+	}()
+
+	By("Closing file")
+	if err = file.Close(); err != nil {
+		return nil, fmt.Errorf("Fail to close file: %s", err.Error())
+	}
+
+	By("File truncating")
+	if err = os.Truncate(file.Name(), int64(size)); err != nil {
+		return nil, fmt.Errorf("Fail to truncate file: %s", err.Error())
+	}
+
+	By("losetup.Attach")
+	dev, err = losetup.Attach(file.Name(), 0, false)
+	if err != nil {
+		return nil, fmt.Errorf("losetup failure: %s", err.Error())
+	}
+
+	defer func() {
+		if err != nil {
+			By("losetup.Detach")
+			dev.Detach() // nolint errcheck
+		}
+	}()
+
+	if err = waitDeviceAppears(&PmemDeviceInfo{Path: dev.Path()}); err != nil {
+		return nil, fmt.Errorf("created loop device not appeared: %s", err.Error())
+	}
+
+	By("Creating volume group")
+	// TODO: reuse vgm code
+	cmdArgs := []string{"--force", dev.Path()}
+	if out, err = pmemexec.RunCommand("pvcreate", cmdArgs...); err != nil { // nolint gosec
+		return nil, fmt.Errorf("pvcreate failure(output:%s): %s", out, err.Error())
+	}
+
+	cmdArgs = []string{"--force", vgname, dev.Path()}
+	if out, err = pmemexec.RunCommand("vgcreate", cmdArgs...); err != nil { // nolint gosec
+		return nil, fmt.Errorf("vgcreate failure(output:%s): %s", out, err.Error())
+	}
+
+	defer func() {
+		if err != nil {
+			By("Removing volume group")
+			pmemexec.RunCommand("vgremove", "--force", vgname)
+		}
+	}()
+
+	By("Append tag(s) to volume group")
+	if out, err = pmemexec.RunCommand("vgchange", "--addtag", string(nsmode), vgname); err != nil {
+		return nil, fmt.Errorf("vgchange failure(output:%s): %s", out, err.Error())
+	}
+
+	return &testVGS{
+		name:       vgname,
+		loopDev:    dev,
+		backedFile: file.Name(),
+	}, nil
+}
+
+func (vg *testVGS) Clean() error {
+	By("Removing volume group")
+	if out, err := pmemexec.RunCommand("vgremove", "--force", vg.name); err != nil {
+		return fmt.Errorf("Fail to remove volume group(output:%s): %s", out, err.Error())
+	}
+
+	By("losetup.Detach()")
+	if err := vg.loopDev.Detach(); err != nil {
+		return fmt.Errorf("Fail detatch loop device: %s", err.Error())
+	}
+
+	By("Removing temp file")
+	if err := os.Remove(vg.backedFile); err != nil {
+		return fmt.Errorf("Fail remove temporary file: %s", err.Error())
+	}
+
+	return nil
+}
+
+func mountDevice(device *PmemDeviceInfo) (string, error) {
+	targetPath, err := ioutil.TempDir("/tmp", "lmv-mnt-path-")
+	if err != nil {
+		return "", err
+	}
+
+	cmd := "mkfs.ext4"
+	args := []string{"-b 4096", "-F", device.Path}
+
+	if _, err := pmemexec.RunCommand(cmd, args...); err != nil {
+		os.Remove(targetPath)
+		return "", err
+	}
+
+	cmd = "mount"
+	args = []string{"-c", device.Path, targetPath}
+
+	if _, err := pmemexec.RunCommand(cmd, args...); err != nil {
+		os.Remove(targetPath)
+		return "", err
+	}
+
+	return targetPath, nil
+}
+
+func unmount(path string) error {
+	args := []string{path}
+	if _, err := pmemexec.RunCommand("umount", args...); err != nil {
+		return err
+	}
+	return os.Remove(path)
+}