-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tensor initialization check for external weights and fixed lint issues #436
Conversation
fix handling of multiple QuantizeLinear nodes
fix debug build
* Update onnx_ctx_model_helper.cc Keep "attr_0" "attr_1" etc inside a scope so that these unique pointers get deleted after their use is over Also declare "node_attributes" global to the new scope (within the function) * Optimizations to reduce memory used during compilation * Fix for reusing the serialized compiled blob to proto model * EpCtx export code refactoring * Fix from Ankit to move memory during ONNX Graph creation * Localise the OV IR model in memory * Apply lint changes --------- Co-authored-by: Vishnudas Thaniel S <[email protected]> Co-authored-by: Javier E. Martinez <[email protected]>
Updated the Version of OV to 2024.3
update: Enable C++ 20 Standard for the build
Reduced model proto scope
Upgrade Openvino version to 2024.3.0
Fix OVEP execution failure with dynamic shaped models
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing this variable across call stack might be difficult to trace in long term. Can you explore the ng_required_initialisers in capability.cc or data_ops.cc
67be471
to
89d0b7c
Compare
External weights can be associated with any initializer in the ONNX model, so we can miss the initializer if we are just traversing the nodes which are not supported as ng_required_initilisers points to the nodes which are not supported, so i believe we should go ahead with my method for now |
LGTM |
236df14
to
b0a8bee
Compare
4d64dc0
to
f9b995c
Compare
@jatinwadhwa921 Rebase with latest changes. |
PR #464 is merged . Closing this as its no longer relevant. |
Refactor tensor initialization check for external weights and fixed lint issues