Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

[Neural Speed] Fix a blocker on Windows platforms #92

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

aahouzi
Copy link
Member

@aahouzi aahouzi commented Jan 24, 2024

Type of Change

  • Fix a blocker that prevents Neural Speed from running on Windows platforms.

Description

  • In your code, you look for the binary if it's a windows, but there is none since in the README we build Neural Speed with setup.py, and not with cmake anymore, so in any case whether it's Linux or Windows we are going to use the executable that can be found in the Neural Speed package.

Expected Behavior & Potential Risk

  • Completes the conversion, quantization and inference successfully.

How has this PR been tested?

  • Tested on my SPR workstation with Win11 OS, and it's working as expected.

Dependency Change?

N/A

Copy link
Contributor

@a32543254 a32543254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aahouzi added a commit to aahouzi/neural-speed that referenced this pull request Jan 29, 2024
@VincyZhang VincyZhang merged commit 4adc150 into intel:main Jan 31, 2024
5 checks passed
@aahouzi aahouzi deleted the bug-fix-windows branch February 20, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants