Neural Coder use INC API by default instead of Optimum #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@chensuyue hi, modification is done: in the future INC launcher will enable INC API, Optimum launcher will enable Optimum API. Optimum PR is huggingface/optimum-intel#183 |
chensuyue
reviewed
Feb 7, 2023
|
|
||
| Pre-requisites: | ||
| ```bash | ||
| pip install transformers==4.21.0 torch datasets |
There was a problem hiding this comment.
How about adding pip install neural-compressor ?
chensuyue
reviewed
Feb 7, 2023
| [+] from torch.backends.quantized import engine; engine = 'onednn' | ||
| [+] from neural_compressor.conf.config import QuantConf | ||
| [+] from neural_compressor.experimental import Quantization, common | ||
| [+] quant_config = QuantConf() |
There was a problem hiding this comment.
Seems it's still using 1.x API, when will Neural Coder migrate into 2.0 API?
There was a problem hiding this comment.
I don't know about the high-level plan, from technical perspective, if INC 2.0 API is ready, then migration is doable at any time
chensuyue
approved these changes
Feb 7, 2023
|
Local test pass, will merge first, please check the comments. |
yuwei-work
approved these changes
Feb 7, 2023
VincyZhang
pushed a commit
that referenced
this pull request
Feb 12, 2023
* update version in all html * fix figure path and cp readme to welcome as default page * fix path * fix path in welcome * fix table format * fix table format * fix table format * fix table format * fix table format * fix path in welcome * fix doc path in readme * fix doc path in readme * fix path in welcome * fix path in welcome * fix link for doc * mv build_docs to docs, restore README.md * including other docs * add 2 product * update structure * add title * add build args * fix error * fix error * fix path * add help, skip remove env * fix error * fix error * add arg * fix versons.html path, support local build --------- Co-authored-by: ZhangJianyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
change logic of which default API design to be enabled
Description
-- Default all use Optimum API for launchers, no matter INC launcher or Optimum launcher
-- If user use INC launcher, then default API is INC API.
-- If user use Optimum launcher, then default API is Optimum API.
Optimum side's modification is in this PR
also refined some backend yamls
also added pre-requisite in Python Launcher example
How has this PR been tested?
locally
Dependency Change?
no