Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use inplace=True mode for WOQ #1557

Merged
merged 10 commits into from
Jan 25, 2024
Merged

use inplace=True mode for WOQ #1557

merged 10 commits into from
Jan 25, 2024

Conversation

xin3he
Copy link
Contributor

@xin3he xin3he commented Jan 22, 2024

Type of Change

enhancement

Description

use inplace mode for WOQ and build 3x API WOQ utility.

  • contiguous is not an in-place op and returns Tensor instead of Parameter, so set it back to m.weight.data.
  • transpose should be executed on Parameter level because Param.data.t_() is not an in-place op.
  • Parameter.T is an in-place op while Tensor.T is not.

Expected Behavior & Potential Risk

UT pass

part of #1549

@xin3he xin3he changed the title use inplace mode for WOQ use inplace=True mode for WOQ Jan 22, 2024
@xin3he xin3he requested a review from Kaihui-intel January 22, 2024 09:06
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
Signed-off-by: xin3he <[email protected]>
chensuyue and others added 6 commits January 23, 2024 20:51
@xin3he xin3he merged commit 31743fe into master Jan 25, 2024
54 checks passed
@xin3he xin3he deleted the xinhe/patch-1 branch January 25, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants