Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Registry for autotune #1543

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Add Config Registry for autotune #1543

merged 9 commits into from
Jan 17, 2024

Conversation

Kaihui-intel
Copy link
Contributor

@Kaihui-intel Kaihui-intel commented Jan 16, 2024

Type of Change

feature

Description

#1445 (comment)

- from neural_compressor.common.base_config import registered_configs
+ from neural_compressor.common.base_config import config_registry

@mengniwang95, @xin3he @zehao-intel Please be aware of the change.

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

Pre-CI

Dependency Change?

None

Copy link
Contributor

@yiliu30 yiliu30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another suggestion, please add the typing hints as much as possible.

neural_compressor/common/base_config.py Outdated Show resolved Hide resolved
neural_compressor/common/base_config.py Outdated Show resolved Hide resolved
neural_compressor/common/base_config.py Outdated Show resolved Hide resolved
neural_compressor/torch/utils/constants.py Show resolved Hide resolved
@yiliu30 yiliu30 added the INC3.X label Jan 16, 2024
Kaihui-intel and others added 3 commits January 16, 2024 15:22
@yiliu30 yiliu30 self-requested a review January 16, 2024 12:26
@Kaihui-intel Kaihui-intel merged commit 09eb5dd into master Jan 17, 2024
24 checks passed
@Kaihui-intel Kaihui-intel deleted the kaihui/tune_config branch January 17, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants