Fix wrong socket number retrieval for non-english system #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Fix intel/intel-extension-for-transformers#762
Description
lscpu | grep 'Socket(s)' | cut -d ':' -f 2may not fetch correct Socket number on non-english system, becauseSocket(s)may be translated to different language, as shown inhttps://github.com/intel/intel-extension-for-transformers/issues/762#issuecomment-1873773702.What we can do is an alternative
cat /proc/cpuinfo | grep 'physical id' | sort -u | wc -l, which should be in pure English to fetch.Expected Behavior & Potential Risk
As above.
How has this PR been tested?
Original UT will be enough.
Dependency Change?
None