feature/intel-mac-support #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intel mac Signed-off-by: Luke Nezda <[email protected]>
nezda
force-pushed
the
feature/intel-mac-support
branch
from
a9577da to
1921855
Compare
for more information, see https://pre-commit.ci
nezda
commented
Dec 28, 2023
|
@nezda thanks for this PR. Looks good to me. Let's wait and see whether the UT pass. If there are coverage issues, please add |
…intel mac Signed-off-by: Luke Nezda <[email protected]>
|
@Spycsh think I got that right. |
Spycsh
approved these changes
Jan 25, 2024
|
Hi @nezda thanks, already approved! Hi @chensuyue , could you have a check and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP make get_number_of_sockets and CpuInfo.get_number_of_sockets work on intel mac
Type of Change
feature or bug fix or documentation or validation or others
API changed or not
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed