Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bias for fx_model #1447

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Add bias for fx_model #1447

merged 4 commits into from
Dec 12, 2023

Conversation

Kaihui-intel
Copy link
Contributor

@Kaihui-intel Kaihui-intel commented Dec 6, 2023

Type of Change

bug fix

Description

AttributeError: 'GraphModule' object has no attribute 'bias' - GeoLayoutLM model
fix issue 1416

Expected Behavior & Potential Risk

How has this PR been tested?

Pre-CI

Dependency Change?

None

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero
Signed-off-by: Tang, Kaihui <[email protected]>
@chensuyue
Copy link
Contributor

target v2.4rc2?

@chensuyue chensuyue added the bug fix Something isn't working label Dec 7, 2023
@Kaihui-intel Kaihui-intel added this to the v2.4 milestone Dec 7, 2023
Copy link
Contributor

@xin3he xin3he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misssing check not isinstance(fx_model.module.weight, torch.Tensor)

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero
Signed-off-by: Tang, Kaihui <[email protected]>
@Kaihui-intel Kaihui-intel requested a review from xin3he December 7, 2023 05:37
Kaihui-intel and others added 2 commits December 8, 2023 09:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Tang, Kaihui <[email protected]>
@Kaihui-intel
Copy link
Contributor Author

/azp run Model-Test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@XuehaoSun XuehaoSun merged commit 7f53d16 into master Dec 12, 2023
@XuehaoSun XuehaoSun deleted the kaihui/pt_bias branch December 12, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants