change use_optimum_format=True and add bias #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
|
shall we specify the format, e.g., use_gptq_format? HF format sounds too general - how about AWQ and GGUF format? People also upload these formats to HF. |
It's actually general, we can generate RTN, AWQ model with this format. GGUF is another format, we haven't supported it now. |
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
PenghuiCheng
approved these changes
Dec 5, 2023
hshen14
approved these changes
Dec 5, 2023
Signed-off-by: Xin He <[email protected]>
Signed-off-by: Xin He <[email protected]>
xin3he
changed the title
|
/azp run Code-Scan |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
bug fix
Description
Optimum sets bias=True for QuantLinear when packing model. Here we follow this design of huggingface format for compatibility and set
use_hf_format=Trueas default.change argument name from hf to optimum.
Expected Behavior & Potential Risk
UT pass