Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new evaluation codes #1372

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Update new evaluation codes #1372

merged 3 commits into from
Nov 16, 2023

Conversation

YIYANGCAI
Copy link
Contributor

@YIYANGCAI YIYANGCAI commented Nov 3, 2023

Original evaluation codes in itrex failed in several CHN LLMs. After updating codes in itrex, such evaluation process in INC's example should also be improved.

Signed-off-by: YIYANGCAI <[email protected]>
@hshen14
Copy link
Contributor

hshen14 commented Nov 3, 2023

Can we import itrex.eval to reuse the code?

@YIYANGCAI
Copy link
Contributor Author

Can we import itrex.eval to reuse the code?

I have considered this once. Since we will call neural compressor in itrex, I am concerned that if we call itrex in a reverse manner, there might be some risks. Could @xin3he give some hints? Thanks!

@chensuyue chensuyue requested a review from xin3he November 16, 2023 03:24
@chensuyue chensuyue merged commit 9906028 into master Nov 16, 2023
10 checks passed
@chensuyue chensuyue deleted the gptq-enhance-eval branch November 16, 2023 05:35
chensuyue added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants