Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llvm sha #277

Merged
merged 14 commits into from
Aug 3, 2022
Merged

Update llvm sha #277

merged 14 commits into from
Aug 3, 2022

Conversation

Hardcode84
Copy link
Contributor

Needed to pull some fixes from upstream.
Changes included

  • InvertCmpi pattern was upstreamed (https://reviews.llvm.org/D129929)
  • Type was removed from mlir Attribute class, cast to TypedAttr where needed
  • spv.OCL ops were named to spv.CL
  • Memref reshape llvm lowering was fixed upstream so our pattern no longer needed (https://reviews.llvm.org/D129965)
  • Invalid tensor cast folding was fixed in upstream (https://reviews.llvm.org/D130314), reenable affected tests, one test still failing due to issue in PropagateLayout pass, will be addressed in separate PR

Copy link
Contributor

@nbpatel nbpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ivan said the Gpu e2e tests pass.

@Hardcode84
Copy link
Contributor Author

Hardcode84 commented Aug 3, 2022

There was an issue with zstd (see failed builds), and it seems it is a misconfiguration on conda-forge side and a known issue (conda-forge/zstd-feedstock#58). Disabling zstd in llvm helped and shouldn't affect us.

Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hardcode84 The build.yml still has an issue with the cache names. Apparently it re-uses the env var CACHE_NUMBER from an earlier step within the build of LLVM. To fix this, we need separate CACHE_NUMBER vars for each step, e.g. change build.yml lines 85 and 89 to use LLVM_CACHE_NUMBER and set it to 1 in line 85 to avoid re-building llvm.

Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hardcode84 !

@Hardcode84 Hardcode84 merged commit 3ab8cfa into intel:main Aug 3, 2022
@Hardcode84 Hardcode84 deleted the update-sha branch August 3, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants