-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llvm sha #277
Update llvm sha #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ivan said the Gpu e2e tests pass.
There was an issue with zstd (see failed builds), and it seems it is a misconfiguration on conda-forge side and a known issue (conda-forge/zstd-feedstock#58). Disabling zstd in llvm helped and shouldn't affect us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hardcode84 The build.yml still has an issue with the cache names. Apparently it re-uses the env var CACHE_NUMBER from an earlier step within the build of LLVM. To fix this, we need separate CACHE_NUMBER vars for each step, e.g. change build.yml lines 85 and 89 to use LLVM_CACHE_NUMBER and set it to 1 in line 85 to avoid re-building llvm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hardcode84 !
Needed to pull some fixes from upstream.
Changes included
InvertCmpi
pattern was upstreamed (https://reviews.llvm.org/D129929)Attribute
class, cast toTypedAttr
where neededspv.OCL
ops were named tospv.CL
PropagateLayout
pass, will be addressed in separate PR