-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoder: HEVC: The VAConfigAttribValEncHEVCBlockSizes and VAConfigAttribValEncHEVCFeatures is not precise for VME #1391
Comments
Thanks @HeJunyan, will correct the value of log2_max_coding_tree_block_size_minus3. Except this, did you notice others? |
And VAConfigAttribValEncHEVCFeatures.cu_qp_delta, MSDK use 3 but the driver gives 2 |
Hi @HeJunyan, VAConfigAttribValEncHEVCFeatures.cu_qp_delta should be 2 (VA_FEATURE_REQUIRED, VA_FEATURE_SUPPORTED=1, VA_FEATURE_NOT_SUPPORTED =0). So this field is correct. |
OK. I just wonder where MSDK get the 3 for this. |
1. optimize call flow 2. add a new attribute list for SCC to correct some incorrect values 3. fixes intel#1391
1. optimize call flow 2. add a new attribute list for SCC to correct some incorrect values 3. fixes intel#1391
1. optimize call flow 2. add a new attribute list for SCC to correct some incorrect values 3. fixes #1391
1. optimize call flow 2. add a new attribute list for SCC to correct some incorrect values 3. fixes #1391
System information
cat /proc/cpuinfo | grep "model name" | uniq
): Tiger Lakelspci -nn | grep -E 'VGA|isplay
): Gen12Issue behavior
Describe the current behavior
The query results of VAConfigAttribValEncHEVCBlockSizes and VAConfigAttribValEncHEVCFeatures for VME(VAEntrypointEncSlice) are not very precise. For example, log2_max_coding_tree_block_size_minus3 is still set to 2, which causes the CTU size still be 32.
In fact, according to MSDK's result, this can be set to 3 and set CTU size to 64. This obsolete parameters do not block our encoding result, but the compression performance may not be good enough.
Describe the expected behavior
Please update these parameters setting, for example, sync with MSDK's setting.
The text was updated successfully, but these errors were encountered: