2020 05 06 sync

Agenda

• Opens
• GitHub issues/PRs
  • https://github.com/intel/llvm/issues/1596 - Unintended different behavior between SYCL and OpenCL attributes
  • https://github.com/intel/llvm/pull/1568 - WIP Replace local clone with SYCL kernel object
• Patches in review for llorg:
  • https://reviews.llvm.org/D71016 - [SYCL] Implement OpenCL kernel function generation
  • https://reviews.llvm.org/D77220 - [SYCL] Enable OpenCL types required for implementing the SYCL headers.
  • https://reviews.llvm.org/D74387 - [SYCL] Do not diagnose use of __float128

Meeting notes

Participants: Alexey Bader (Intel), Mariya Podchischaeva (Intel), Roland Schulz (Intel), Ronan Keryell (Xilinx), Nevin Liber (ANL)

• Opens

  • Mariya: https://github.com/intel/llvm/pull/1581 is merged. What is our next steps?

  • Alexey: Let's submit it to llorg for review.

  • Mariya: What are we going to do with the OpenCL C++ bug exposed by this change?

  • Alexey: Disable the impacted test and ping Anastasia.

  • Roland: Are we agreed that using std types for SYCL kernel names shouldn't be allowed? See https://github.com/intel/llvm/pull/1579.

  • Alexey: Agree. Let's keep the diagnostics part.

• GitHub issues/PRs

  • https://github.com/intel/llvm/issues/1596 - Unintended different behavior between SYCL and OpenCL attributes
    • Alexey: SYCL spec doesn't define address space keywords/attributes - only special template class, so expectations on difference between SYCL and OpenCL in attributes behavior difference are not very clear.
    • Alexey: diagnostics for SYCL and OpenCL modes implemented differently. SYCL uses "deferred diagnostics engine" to delay "report decision" until we know that code is compiled for the device.
    • Roland: we should enable as much OpenCL diagnostics for OpenCL address space attributes in SYCL mode as possible.
    • Alexey: okay. Let's go over OpenCL diagnostics for address space attributes and remove "if (LangOpts.OpenCL)" condition where it makes sense to share the diagnostics with SYCL mode.
  • https://github.com/intel/llvm/pull/1568 - WIP Replace local clone with SYCL kernel object
    • Alexey: FYI, after thorough review we decided to abandon this approach due to OpenCL environment specification limitation prohibiting using OpenCL types like images and sampler as structure members.

• Patches in review for llorg:

  • https://reviews.llvm.org/D71016 - [SYCL] Implement OpenCL kernel function generation
    • No updates.
    • Alexey: I'd like to get additional clarification on SemaSYCL.cpp refactoring requested by Victor. Will do later.
  • https://reviews.llvm.org/D77220 - [SYCL] Enable OpenCL types required for implementing the SYCL headers.
    • Pending previous one.
  • https://reviews.llvm.org/D74387 - [SYCL] Do not diagnose use of __float128
    • Mariya: waiting for reply from Johannes. Will ping him.