Update implementation of built-in functions #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a wrapper of boolean vector. Used the wrapper in the implementation of relational built-in functions. Fixed isnormal for scalar double for the host side. Fixed select for genfloatd and genfloath. Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Alexey Voronov <[email protected]>
The GPU SPIRV translator cannot handle those function with the vector first argument type and the scalar type second /third argument together. Signed-off-by: Alexey Voronov <[email protected]>
This function has the accuracy that implementation-defined and cannot checked independed. Simply calling of this function is checked by CTS. Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Alexey Voronov <[email protected]>
Fix macro __HAFL_ENABLED. Signed-off-by: Alexey Voronov <[email protected]>
Removed I/O. Replace namespace cl::sycl to s for the tests. Signed-off-by: Alexey Voronov <[email protected]>
Removed a code duplication. Moved the common implementation functions to anonymous namespace. Signed-off-by: Alexey Voronov <[email protected]>
Signed-off-by: Alexey Voronov <[email protected]>
bader
approved these changes
Apr 20, 2019
bb-sycl
pushed a commit
that referenced
this pull request
Feb 11, 2021
This patch implemented TTI.IntImmCost() properly. Each BPF insn has 32bit immediate space, so for any immediate which can be represented as 32bit signed int, the cost is technically free. If an int cannot be presented as a 32bit signed int, a ld_imm64 instruction is needed and a TCC_Basic is returned. This change is motivated when we observed that several bpf selftests failed with latest llvm trunk, e.g., #10/16 strobemeta.o:FAIL #10/17 strobemeta_nounroll1.o:FAIL #10/18 strobemeta_nounroll2.o:FAIL #10/19 strobemeta_subprogs.o:FAIL #96 snprintf_btf:FAIL The reason of the failure is due to that SpeculateAroundPHIsPass did aggressive transformation which alters control flow for which currently verifer cannot handle well. In llvm12, SpeculateAroundPHIsPass is not called. SpeculateAroundPHIsPass relied on TTI.getIntImmCost() and TTI.getIntImmCostInst() for profitability analysis. This patch implemented TTI.getIntImmCost() properly for BPF backend which also prevented transformation which caused the above test failures. Differential Revision: https://reviews.llvm.org/D96448
iclsrc
pushed a commit
that referenced
this pull request
Dec 21, 2023
This PR adds support for thread names in lldb on Windows. ``` (lldb) thr list Process 2960 stopped thread #53: tid = 0x03a0, 0x00007ff84582db34 ntdll.dll`NtWaitForMultipleObjects + 20 thread #29: tid = 0x04ec, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'SPUW.6' thread #89: tid = 0x057c, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1000019] physics[main]' thread #3: tid = 0x0648, 0x00007ff843c2cafe combase.dll`InternalDoATClassCreate + 39518 thread #93: tid = 0x0688, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x100501d] uMovie::StreamingThread' thread #1: tid = 0x087c, 0x00007ff842e7a104 win32u.dll`NtUserMsgWaitForMultipleObjectsEx + 20 thread #96: tid = 0x0890, 0x00007ff845830a14 ntdll.dll`NtWaitForAlertByThreadId + 20, name = 'PPU[0x1002020] HLE Video Decoder' <...> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the host side integer and geometric built-in functions.
Refactoring of the host side built-in functions and built-in functions' tests.
Enable half variants of built-ins.