Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix post commit failure on Windows. #7582

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

srividya-sundaram
Copy link
Contributor

Fixes post-commit failure reported in #7483

@srividya-sundaram srividya-sundaram requested a review from a team as a code owner November 29, 2022 21:37
smanna12
smanna12 previously approved these changes Nov 29, 2022
@smanna12 smanna12 self-requested a review November 29, 2022 23:09
@smanna12 smanna12 dismissed their stale review November 30, 2022 00:17

wrong change

@pvchupin
Copy link
Contributor

pvchupin commented Nov 30, 2022

@premanandrao, @srividya-sundaram, is it ready to merge? approval is missing.
Local check would be enough. Post-commit will verify.

@premanandrao
Copy link
Contributor

@premanandrao, @srividya-sundaram, is it ready to merge? approval is missing. Local check would be enough. Post-commit will verify.

If @srividya-sundaram can confirm that it passes on Windows locally, I can approve.
Or if you think we should check it in and let post-commit confirm, I can approve now.

@pvchupin pvchupin merged commit b84f0b2 into intel:sycl Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants