Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ROCm] Fix missing parameter in ROCm plugin #4166

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

npmiller
Copy link
Contributor

This parameter was introduced in #4066 but apparently didn't make it in
the ROCm plugin.

This parameter was introduced in intel#4066 but apparently didn't make it in
the ROCm plugin.
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing ROCm build in testing that it was left unnoticed?

@bader bader merged commit 4614ee4 into intel:sycl Jul 22, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Jul 27, 2021
…ackend_plugin

* upstream/sycl: (755 commits)
  [SYCL] Add operator= to atomic_ref specializations (intel#4183)
  [SYCL] Make spelling of Debug value for CMAKE_BUILD_TYPE variable case insensitive (intel#4069)
  [SYCL][LIBCLC] Add atan and cbrt for amdgcn-amdhsa (intel#4180)
  [SYCL][CUDA] Correctly free managed memory (intel#4181)
  [SYCL] Revert barrier deprecation note (intel#4162)
  [SYCL][FPGA] Refactor of statement attributes (intel#4136)
  [Driver][SYCL] Enable way to emit int-footer source to a specific dir (intel#4167)
  [Driver] Fix default MSVC version setting for -fms-compatibilty-version (intel#4165)
  [BuildBot] Add llvm-enable-projects flag to configure.py (intel#4169)
  [Driver][SYCL][FPGA] Improve aocx archive processing for FPGA (intel#4160)
  [SYCL] Correct int-header emission with type aliases
  [SYCL] Fix name collisions in SYCL enums (intel#4154)
  [SYCL] Return the correct status info for host_task event (intel#4161)
  [ESIMD][NFC] Added tests for simd class type traits (intel#4146)
  [SYCL][ROCm] Fix missing parameter in ROCm plugin (intel#4166)
  [SYCL][L0] Add temporary option to allow user to use copy engine for device to device copy (intel#4127)
  Remove check for AMD HIP to fix Driver/cuda-arch-translation.cu
  Reapply after conflict resolution 418a6d6 "Fix nvptx_target_teams_distribute_parallel_for_simd_codegen failure"
  Revert "[SYCL] Removes redefinitions of macros in libclc (intel#3505)"
  [PGO] Change test-run line to check NewPM pass behavior
  ...
@bader bader added the hip Issues related to execution on HIP backend. label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hip Issues related to execution on HIP backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants