[SYCL][USM] Initial Support for USM #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Jun 26, 2019
| @@ -1,4 +1,4 @@ | |||
| // RUN: %clang -std=c++11 -fsycl %s -o %t.out -lstdc++ -lOpenCL -lsycl | |||
| // RUN: env ENABLE_INFER_AS=1 %clang -std=c++11 -fsycl %s -o %t.out -lstdc++ -lOpenCL -lsycl | |||
There was a problem hiding this comment.
AFAIK, this variable is not needed.
There was a problem hiding this comment.
It is. Adding pointers requires this mode to be enabled in the compiler. Otherwise conversations between global/generic aren't properly handled.
|
Also, to pass Please, add [SYCL] and [USM] tags to your commit title to make it easier to find in the history. |
1) Support pointer types in Integration Header 2) Put kernel pointer params in the global addr space 3) Fix CheckSYCLType to support proper recursion through pointers Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Modify test to use generic address space switch in order to pass. Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
|
The idea looks good. |
bader
previously approved these changes
Jun 28, 2019
| // CHECK-OLD: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{ | ||
| // CHECK-NEW: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32 addrspace(4)*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{ | ||
|
|
||
| // CHECK: define{{.*}} spir_kernel {{.*}}void @_ZTSZ4mainE15kernel_function(i32 addrspace(1)*{{.*}}){{.*}} !dbg [[KERNEL:![0-9]+]] {{.*}}{ |
There was a problem hiding this comment.
Interesting.
@asavonic, this looks like a bug with address space handling.
- Note, clang emit OpenCL kernel with "generic pointer" argument.
- Clang does not emit warnings about captured pointers.
I think both these issues should be fixed for the cases when USM feature is not available.
bader
approved these changes
Jul 1, 2019
bb-sycl
pushed a commit
that referenced
this pull request
Aug 3, 2021
…shifted
Add a comment when there is a shifted value,
add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.
Differential Revision: https://reviews.llvm.org/D107196
bb-sycl
pushed a commit
that referenced
this pull request
Apr 15, 2022
…n a loop
When untagging the stack, the compiler may emit a sequence like:
```
.LBB0_1:
st2g sp, [sp], #32
sub x8, x8, #32
cbnz x8, .LBB0_1
stg sp, [sp], #16
```
These stack adjustments cannot be described by CFI instructions.
This patch disables merging of SP update with untagging, i.e. makes the
compiler use an additional scratch register (there should be plenty
available at this point as we are in the epilogue) and generate:
```
mov x9, sp
mov x8, #256
stg x9, [x9], #16
.LBB0_1:
sub x8, x8, #32
st2g x9, [x9], #32
cbnz x8, .LBB0_1
add sp, sp, #272
```
Merging is disabled only when we need to generate asynchronous unwind
tables.
Reviewed By: eugenis
Differential Revision: https://reviews.llvm.org/D114548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies clang to supports pointers.
Adds pointers to the Integration header object types in clang/sycl rt.
Fixes a couple of tests to work properly with these changes.