[SYCL] Build sycl/tools with same CXX STD settings as set for sycl #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having differnet CMAKE_CXX_STANDARD/CMAKE_CXX_STANDARD_REQUIRED/CMAKE_CXX_EXTENSIONS may lead to errors during build of sycl/tools. Removing explicit setting of those 3 parameters in sycl/tool/CMakeLists.txt in this patch syncs the build settings of sycl/tools and sycl libraries. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
Without this fix I have build errors like the one below during the sycl/tools build (with my changes being in development): |
vladimirlaz
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having differnet CMAKE_CXX_STANDARD/CMAKE_CXX_STANDARD_REQUIRED/CMAKE_CXX_EXTENSIONS
may lead to errors during build of sycl/tools.
Removing explicit setting of those 3 parameters in sycl/tool/CMakeLists.txt
in this patch syncs the build settings of sycl/tools and sycl libraries.
Signed-off-by: Vyacheslav N Klochkov [email protected]