Revert "[SYCL] disallow mutable lambdas" #2213
Conversation
This reverts commit a43dcc2.
romanovvlad
requested review from
elizabethandrews,
Fznamznon,
premanandrao and
a team
as code owners
|
The patch breaks CTS. |
|
Are you reverting this because of the failure in test_hierarchical_opencl? I saw the same test fail in the same way with PR 2159. I wondered if it might be a flaky test issue. |
No. Do not think these fails are connected. |
OK, I see. There are many other failures here. I didn't see the others in the partial Jenkins log file in the first view I got. Thanks. |
The real regressions are. All next post-comit jobs have the same failures. [2020-07-29T17:54:20.319Z] [2020-07-29 17:54:19,847] SYCL CTS INFO: List of new failures: [2020-07-29T17:54:20.319Z] test_stream_opencl [2020-07-29T17:54:20.319Z] test_opencl_interop_opencl [2020-07-29T17:54:20.319Z] test_accessor_opencl [2020-07-29T17:54:20.319Z] test_atomic_opencl [2020-07-29T17:54:20.319Z] test_invoke_opencl [2020-07-29T17:54:20.319Z] test_program_opencl [2020-07-29T17:54:20.319Z] test_event_opencl [2020-07-29T17:54:20.319Z] test_handler_opencl [2020-07-29T17:54:20.319Z] test_kernel_opencl [2020-07-29T17:54:20.319Z] test_item_opencl [2020-07-29T17:54:20.319Z] test_nd_item_opencl |
…rogram * upstream/sycl: [SYCL] Add barrier before leader guard in LowerWGSCope pass (intel#2208) [SYCL] Add prototype of atomic_ref<T*> (intel#2177) Revert "[SYCL] Disallow mutable lambdas (intel#1785)" (intel#2213)
#2213) Previously added scalar/vector ConvertFToBF16INTEL, ConvertBF16ToFINTEL and RoundFToTF32INTEL conversions are now enabled for cooperative matrix type under SPV_INTEL_joint_matrix extension following the spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_joint_matrix.asciidoc Note, joint matrices are not allowed as input/output for these conversions as it is being deprecated. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@1010efc
Reverts #1785