Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][NFC] Fix ac_float test for compilation with FE optimizations #2184

Merged
merged 4 commits into from
Jul 29, 2020
Merged

[SYCL][NFC] Fix ac_float test for compilation with FE optimizations #2184

merged 4 commits into from
Jul 29, 2020

Conversation

mlychkov
Copy link
Contributor

Signed-off-by: Mikhail Lychkov [email protected]

@mlychkov mlychkov requested a review from a team as a code owner July 27, 2020 17:32
@mlychkov mlychkov requested a review from alexbatashev July 27, 2020 17:32
@bader bader changed the title Fix ac_float test for compilation with FE optimizations [SYCL][NFC] Fix ac_float test for compilation with FE optimizations Jul 27, 2020
@bader bader requested a review from MrSidims July 27, 2020 18:09
alexbatashev
alexbatashev reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like @MrSidims to approve first

@MrSidims
Copy link
Contributor

I don't get it. I was thinking that we are getting an empty module with the optimizations enable and hence we need to add side effects to the functions in the test. From what I see, this patch just changes CHECK strings, so the only thing that has changed is variable names?

Please also move the test to check_device_code, I think it fits to it better than to 'fpga_tests'.

@mlychkov
Copy link
Contributor Author

I don't get it. I was thinking that we are getting an empty module with the optimizations enable and hence we need to add side effects to the functions in the test. From what I see, this patch just changes CHECK strings, so the only thing that has changed is variable names?

Yes, calls are still present, only differ a bit from unoptimized version.

Please also move the test to check_device_code, I think it fits to it better than to 'fpga_tests'.

Moved this and ac_fixed tests into check_device_code dir.

@bader bader requested a review from alexbatashev July 28, 2020 14:00
@bader bader merged commit 226bc2a into intel:sycl Jul 29, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jul 30, 2020
Merge remote-tracking branch 'upstream/sycl' into enable_kernel_and_p…
549736c 
…rogram

* upstream/sycl: (609 commits)
  [SYCL] Fix fail in the post commit testing (intel#2210)
  [SYCL] Materialize shadow local variables for byval arguments before use (intel#2200)
  [SYCL] Support lambda functions passed to reduction (intel#2190)
  [SYCL][USM] Improve USM Allocator. (intel#2026)
  [SYCL] Disallow mutable lambdas (intel#1785)
  [SYCL][ESIMD] Setup compilation pipeline for ESIMD (intel#2134)
  [SYCL] Fix not found kernel due to empty kernel name when using set_arg(s) (intel#2181)
  [SYCL] Fixed check for set_arg (intel#2203)
  Refactor indirect access calls to minimize invocations. (intel#2185)
  [SYCL][NFC] Fix potential null-pointer access (intel#2197)
  [SYCL] Propagate attributes from transitive calls to kernel (intel#1878)
  [SYCL] Fix warnings from static analysis tool (intel#2193)
  [SYCL][NFC] Fix ac_float test for compilation with FE optimizations (intel#2184)
  [GitHub Actions] Uplift clang-format version to 10 (intel#2194)
  [SYCL][ESIMD] Pass to replace simd* parameters with native llvm vectors. (intel#2097)
  [SYCL][NFC] Fixed SYCL_PI_TRACE output while selecting a device. (intel#2192)
  [SYCL][FPGA] New spec for controlling load-store units in FPGAs (intel#2158)
  [SYCL][Doc] Clarify reqd_sub_group_size (intel#2103)
  [SYCL] Remove noreturn function attribute (intel#2165)
  [SYCL] Aligned set_arg behaviour with SYCL specification (intel#2159)
  ...
@mlychkov mlychkov deleted the private/mlychkov/fix_ac_float_test_with_opt branch August 7, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@MrSidims MrSidims MrSidims approved these changes

@alexbatashev alexbatashev alexbatashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlychkov @MrSidims @bader @alexbatashev