[SYCL][CUDA][LIT] Fix base address get and subbuffer LIT test #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemektmalon
force-pushed
the
przemek/cuda-fix-base-addr-info-and-subbuffer-lit
branch
from
446ede1
to
1747afe
Compare
This commit fixes a hardcoded value for base address alignment in the cuda backend. Also a hardcoded value that should be dependant on the base address alignment is fixed in the subbuffer LIT test, which now passes on CUDA. Signed-off-by: Przemek Malon <[email protected]>
przemektmalon
force-pushed
the
przemek/cuda-fix-base-addr-info-and-subbuffer-lit
branch
from
1747afe
to
788ac4e
Compare
|
@fwyzard FYI |
|
@Ruyk Could you please take a look? |
| @@ -1,6 +1,3 @@ | |||
| // XFAIL: cuda | |||
| cl::sycl::detail::pi::assertion( | ||
| cuDeviceGetAttribute(&mem_base_addr_align, | ||
| CU_DEVICE_ATTRIBUTE_TEXTURE_ALIGNMENT, | ||
| device->get()) == CUDA_SUCCESS); |
There was a problem hiding this comment.
Przemek and I discussed offline - the reported value aligns with the hard-coded value before. This alignment is probably required to enable creation of images, e.g., CL_MEM_OBJECT_IMAGE1D_BUFFER, from sub-buffers.
|
+1 |
romanovvlad
approved these changes
Jun 18, 2020
Ruyk
approved these changes
Jun 18, 2020
przemektmalon
deleted the
przemek/cuda-fix-base-addr-info-and-subbuffer-lit
branch
Closed
bb-sycl
pushed a commit
that referenced
this pull request
Apr 4, 2023
Extension name will be preserved for a while for binary compatibility. Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@68855f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a hardcoded value for base address alignment
in the CUDA backend. Also a hardcoded value that should be
dependant on the base address alignment is fixed in the subbuffer
LIT test, which now passes on CUDA.
Signed-off-by: Przemek Malon [email protected]