-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL-PTX] Fix geometric and common builtin categories #1832
Conversation
63c74ae
to
71ad4c9
Compare
LGTM |
@Naghasan, could you resolve merge conflicts, please? |
71ad4c9
to
92d12c8
Compare
@Naghasan, could you resolve merge conflicts, please? |
92d12c8
to
7845b18
Compare
I rebased the patch |
7845b18
to
0347435
Compare
@bader I have rebased to tip, I'm sure why the build failed before. Last version compiles fine on my side. |
According to the logs
|
Signed-off-by: Victor Lomuller <[email protected]> Co-authored-by: David Wood <[email protected]>
Oh I see what happened now, not all the target where built on my side and there is a This is fixed. |
0347435
to
d639934
Compare
Remove old forward declared SPIR-V builtin from the geometric and common categories.
Update the binding file using the header generator.
Add relevant binding test.
Remove XFAIL from related SYCL tests.
Note there is a dependency with #1828 but can be reviewed independently.
Signed-off-by: Victor Lomuller [email protected]