-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Implement eviction in persistent cache #16289
Open
uditagarwal97
wants to merge
8
commits into
intel:sycl
Choose a base branch
from
uditagarwal97:eviction_persistent_cache
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+608
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
December 5, 2024 18:01 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 5, 2024 18:01 — with
GitHub Actions
Error
uditagarwal97
force-pushed
the
eviction_persistent_cache
branch
from
December 5, 2024 18:02
d04b01a
to
44773dc
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
December 5, 2024 18:04 — with
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
December 5, 2024 18:38 — with
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
December 5, 2024 21:13 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 6, 2024 06:07 — with
GitHub Actions
Failure
uditagarwal97
force-pushed
the
eviction_persistent_cache
branch
from
December 8, 2024 23:33
3150a60
to
3a23d2d
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
December 8, 2024 23:33 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 8, 2024 23:34 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 8, 2024 23:54 — with
GitHub Actions
Error
uditagarwal97
force-pushed
the
eviction_persistent_cache
branch
from
December 9, 2024 00:10
3a23d2d
to
145e81f
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
December 9, 2024 00:11 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 9, 2024 01:49 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 9, 2024 20:13 — with
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
December 9, 2024 20:58 — with
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
December 9, 2024 21:34 — with
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
December 12, 2024 17:38 — with
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
December 12, 2024 19:05 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements eviction for persistent cache.
Eviction is disabled by default and can be controlled by the user via
SYCL_CACHE_MAX_SIZE
variable.Here's how eviction works:
cache_size.txt
, is stored at the root of persistent cache. Every time a process adds a new entry to cache, it will also update thecache_size.txt
file. This file is used to track the size of persistent cache. For backwards compatibility, if SYCL RT does not findcache_size.txt
in the cache root, it will create once. All access tocache_size.txt
are done usingLockCacheItem
, to prevent data races.cache_size.txt
file and if the cache size exceeds the threshold, eviction is triggered.stat
or Window'sGetFileAttribute
). Items are evicted based on the LRU policy.