Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Adjust CompileTimePropertiesPass for sycl_ext_oneapi_prefetch #11597

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

KornevNikita
Copy link
Contributor

The first part: #11458

Adjust the CompileTimePropertiesPass so it can convert new properties into spirv decorations.

The first part: intel#11458

Adjust the CompileTimePropertiesPass so it can convert new properties into
spirv decorations.
@KornevNikita KornevNikita requested a review from a team as a code owner October 19, 2023 12:47
@KornevNikita KornevNikita marked this pull request as draft October 19, 2023 13:13
@KornevNikita KornevNikita temporarily deployed to WindowsCILock October 19, 2023 13:27 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to WindowsCILock October 19, 2023 15:06 — with GitHub Actions Inactive
KornevNikita added a commit to KornevNikita/SPIRV-LLVM-Translator that referenced this pull request Oct 19, 2023
SYCL part: intel/llvm#11458
intel/llvm#11597

Handle new properties and decorate prefetch's arg.
@KornevNikita KornevNikita temporarily deployed to WindowsCILock October 19, 2023 15:52 — with GitHub Actions Inactive
@KornevNikita KornevNikita marked this pull request as ready for review October 20, 2023 07:28
@KornevNikita
Copy link
Contributor Author

I guess this failure is unrelated.

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Jut waiting on one minor clarification.

Thanks

@KornevNikita KornevNikita temporarily deployed to WindowsCILock October 23, 2023 09:22 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to WindowsCILock October 23, 2023 09:59 — with GitHub Actions Inactive
@KornevNikita KornevNikita requested a review from asudarsa October 23, 2023 18:20
@KornevNikita
Copy link
Contributor Author

@intel/sycl-language-enabling-triage take a look please.

MrSidims pushed a commit to KhronosGroup/SPIRV-LLVM-Translator that referenced this pull request Oct 26, 2023
SYCL part: intel/llvm#11458
intel/llvm#11597

Handle new properties and decorate prefetch's arg.
@againull againull merged commit 0229456 into intel:sycl Oct 27, 2023
10 checks passed
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsji pushed a commit that referenced this pull request Nov 2, 2023
SYCL part: #11458
#11597

Handle new properties and decorate prefetch's arg.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a76f24e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants