-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Adjust CompileTimePropertiesPass for sycl_ext_oneapi_prefetch #11597
Conversation
The first part: intel#11458 Adjust the CompileTimePropertiesPass so it can convert new properties into spirv decorations.
SYCL part: intel/llvm#11458 intel/llvm#11597 Handle new properties and decorate prefetch's arg.
I guess this failure is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Jut waiting on one minor clarification.
Thanks
@intel/sycl-language-enabling-triage take a look please. |
SYCL part: intel/llvm#11458 intel/llvm#11597 Handle new properties and decorate prefetch's arg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SYCL part: #11458 #11597 Handle new properties and decorate prefetch's arg. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a76f24e
The first part: #11458
Adjust the CompileTimePropertiesPass so it can convert new properties into spirv decorations.