LIT XFAIL spec_const tests passing with Intel OpenCL GPU 20.19.16754

[bjoernknafla]

After noticing in buildbot/dependency.conf to update to the Intel OpenCL GPU driver 20.19.16754 I am now seeing two LIT XFAILs for OpenCL pass:

cd <BUILD-DIR>
./bin/llvm-lit -a -v tools/sycl/test --param SYCL_BE=PI_OPENCL --filter=.*spec.*

...

Unexpectedly Passed Tests (2):
  SYCL :: spec_const/spec_const_hw.cpp
  SYCL :: spec_const/spec_const_redefine.cpp

Current tip commit: da6bfd0

However, I do not see them pass in the PR buildbot runs and try to figure out if to update to the newer driver, or not.

Are these expected with the mentioned driver version?
Are the buildbot machines using a different driver version?

[bader]

I suppose these tests still fail on non-GPU devices.
The buildbot expects these tests to pass on all the configured devices.

Feel free to adjust the XFAIL pattern to fix status on your configuration.

[bjoernknafla]

@bader From what I see they are passing now for all OpenCL devices (though I do not have access to an FPGA for testing).

Do you want me to open a PR that removes the XFAILs - although I expect this to then fail the buildbots?

[bader]

I was thinking about something like this:

// XFAIL: linux && opencl && !gpu && !cpu

[bjoernknafla]

@bader That is a neat idea! PR with your idea is here: #1875