Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA][HIP] Expand Config/select_device.cpp for CUDA and HIP #1086

Merged
merged 21 commits into from
Aug 9, 2022
Merged

[SYCL][CUDA][HIP] Expand Config/select_device.cpp for CUDA and HIP #1086

merged 21 commits into from
Aug 9, 2022

Conversation

sami-hatna66
Copy link

Fixes the test select_device.cpp so that it now passes for CUDA and HIP backends.

sami-hatna66 and others added 16 commits July 7, 2022 14:50
@sami-hatna66
WRITE_DEVICE_INFO now passes for CUDA and HIP backends
0bdcce9
@sami-hatna66
WRITE_PLATFORM_INFO now passes for CUDA and HIP backends
7f3d8b6
@sami-hatna66
Add backend::level_zero to conditions (guard for when ext_oneapi_leve…
a883df0 
…l_zero is eventually deprecated)
@sami-hatna66
Delete select_device.out
326b7f1
@sami-hatna66
Delete select_device_config.txt
4ee23ba
@sami-hatna66
Delete SYCL/Config/.vscode directory
88852fd
@sami-hatna66
Add backend::level_zero to conditions (guard for when ext_oneapi_lev…
14239f3 
…el_zero is eventually deprecated)
@sami-hatna66
WRITE_PLATFORM_ERROR_INFO now passes for CUDA and HIP backends
8d7f4c0
@sami-hatna66
WRITE_REG_EX_INFO now passes for CUDA and HIP backends
3f076c9
@sami-hatna66
WRITE_DEVICE_MULTI_INFO and WRITE_DEVICE_MALFORMED_INFO now pass for …
eab7564 
…CUDA and HIP backends
@sami-hatna66
WRITE_PLATFORM_MALFORMED_INFO now passes for CUDA and HIP backends
abae4d6
@sami-hatna66
WRITE_DRIVER_MALFORMED_INFO now passes for CUDA and HIP backends
4e1e021
@sami-hatna66
WRITE_PLATVER_MALFORMED_INFO now passes for CUDA and HIP backends
7f55e89
@sami-hatna66
Update top comment
90697f3
@sami-hatna66
[SYCL][HIP][CUDA] Merge pull request #1 from sami-hatna66/modify_sele…
499f6a4 
…ct_device_for_CUDA_HIP

Modify select device for cuda hip
@sami-hatna66
Ran clang-format
dd2740e
@sami-hatna66 sami-hatna66 requested a review from a team as a code owner July 12, 2022 08:12
againull
againull suggested changes Jul 12, 2022
View reviewed changes
SYCL/Config/select_device.cpp Outdated Show resolved Hide resolved
SYCL/Config/select_device.cpp Outdated Show resolved Hide resolved
againull
againull reviewed Jul 13, 2022
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
SYCL/Config/select_device_config.txt Outdated Show resolved Hide resolved
@sami-hatna66 sami-hatna66 marked this pull request as draft July 19, 2022 07:36
@sami-hatna66 sami-hatna66 marked this pull request as ready for review July 19, 2022 07:36
@AerialMantis AerialMantis mentioned this pull request Aug 5, 2022
Closed
@AerialMantis
Copy link

@pvchupin @againull I think all the requested changes have been made, could we get another review of this, and perhaps re-run the tests?

@pvchupin
Copy link

pvchupin commented Aug 9, 2022

Restarted testing. @againull pls review.

@againull againull merged commit 2c6eb63 into intel:intel Aug 9, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@sami-hatna66 @bb-sycl
[SYCL][CUDA][HIP] Expand Config/select_device.cpp for CUDA and HIP (i…
21c0ae6 
…ntel#1086)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@sami-hatna66
[SYCL][CUDA][HIP] Expand Config/select_device.cpp for CUDA and HIP (i…
dbe000d 
…ntel/llvm-test-suite#1086)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@againull againull againull approved these changes

@pvchupin pvchupin Awaiting requested review from pvchupin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sami-hatna66 @AerialMantis @pvchupin @againull