Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Modify listner, filter, cluster syntax to match with envoy API v3 sta… #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify listner, filter, cluster syntax to match with envoy API v3 sta… #67

wants to merge 1 commit into from

Conversation

zhqffrank
Copy link

…ndards

@zhqffrank
Copy link
Author

Modify listner, filter, cluster syntax to match with envoy API v3 standards for file nginx-behind-envoy-deployment.yaml

mythi
mythi suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! let's drop the qat.intel.com resource specific changes and focus the envoy config/commandline fixes.

deployments/nginx-behind-envoy-deployment.yaml Show resolved Hide resolved
deployments/nginx-behind-envoy-deployment.yaml Show resolved Hide resolved
deployments/nginx-behind-envoy-deployment.yaml Show resolved Hide resolved
@zhqffrank zhqffrank closed this Mar 21, 2022
@mythi
Copy link
Contributor

mythi commented Mar 21, 2022

@zhqffrank no need to close but if you plan to force push with updates remember to re-open this PR first

@zhqffrank zhqffrank reopened this Mar 21, 2022
@zhqffrank
Copy link
Author

Reopen for merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mythi mythi mythi requested changes

@ipuustin ipuustin ipuustin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhqffrank @mythi @ipuustin