Simplify EOS token handling in tokenize function #12866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the tokenizer handle EOS token
|
@Oscilloscope98 can you review this ? Thanks! |
Uxito-Ada
reviewed
Feb 21, 2025
| ): | ||
| result["input_ids"].append(tokenizer.eos_token_id) | ||
| result["attention_mask"].append(1) | ||
| add_special_tokens=add_eos_token, |
There was a problem hiding this comment.
Hi @DreadPirate09 ,
Thanks for your contribution. The code previously manually appends EOS token because add_special_token=True will add both a BOS and EOS at the beginning and end respectively, as illustrated here. Therefore, I think add_special_token does not exactly match add_eos_token's semantics.
There was a problem hiding this comment.
Ok ... I understand now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the tokenizer handle EOS token