Merge OpenAI Triton commit 4f6f768
#2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes special cases for MFMA -> Dot Operand LDS shortcuts. Now it is supported by common linear layout infrastructure. No tests are added, mfma-shortcut.mlir already testing this.
`scaled_dot` is not yet implemented on `gfx11` and `gfx12` so disable unit tests for now.
The string representation allows PyTorch Inductor to serialize/derserialize the `AttrsDescriptor` to the `@triton.heuristics` block in the generated code.
Allows for upcasting in DotOp encoding in RF. This lowering path is not currently in use; pending triton-lang/triton#5003
…indows (#5014) The `-A` argument is not compatible with the Ninja generator. Signed-off-by: Anatoly Myachev <[email protected]>
In the passing we also improve a few other things: - Now `scaled_dot` accepts both uint8/uint16 fp8/bf16 as inputs (before you had to cast it to uint8, which was weird when extending it to bf16). - Add `scaled_dot` to the docs and improve the docs overall (have not render them, might need a few further tweaks)
…Py HALF-related code (#5010) Closes #4992
Example:
```python
# On Windows
>>> sysconfig.get_config_var("EXE")
'.exe'
# On Linux
>>> sysconfig.get_config_var("EXE")
''
```
---------
Signed-off-by: Anatoly Myachev <[email protected]>
This PR adds more restrictions about when should we apply the sched-load optimizations and un-revert triton-lang/triton#4823. We will only apply the optimization when all of the following is satisfied: 1. pureMatmulProblem, i.e. 1 `tt.dot` in the main loop 2. two `tt.load`s in the main loop 3. 2nd `tt.load` is ahead of the `tt.dot` 4. 1st user of 2nd `tt.load` is after the `tt.dot` 5. tile size is large enough, i.e. nonKDim >= 128 and kDim >= 64
anmyachev
approved these changes
Nov 5, 2024
whitneywhtsang
force-pushed
the
whitneywhtsang/merge
branch
from
b8fdbe3 to
49a52a2
Compare
whitneywhtsang
changed the title
ebce7f34f6f768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the Triton base from 86a2ac7 to 4f6f768 (Oct 30).
Pass rate: 97.41%->96.31% (#2633)
Please do not squash and merge this PR.