Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decryption when using CIPHER_HASH order does not produce right output #33

Closed
pablodelara opened this issue Mar 14, 2019 · 1 comment
Closed

Decryption when using CIPHER_HASH order does not produce right output #33

pablodelara opened this issue Mar 14, 2019 · 1 comment
Labels
bug

Comments

@pablodelara
Copy link
Contributor

When flushing a job decrypting before hashing (where hash operation is not completed, but decryption operation is), the buffer is again decrypted, producing an incorrect output.

Currently, the unit tests do not expose this issue, as this combination is not tested (chain_order = CIPHER_HASH, cipher_direction = DECRYPT, hash_alg != NULL_HASH). New tests will be added, testing this and other chained operation combinations.
tkanteck pushed a commit that referenced this issue Mar 15, 2019
@pablodelara
Fix flush decryption job. Fix for issue #33
b43b327 
When flushing a job, which decryption operation was
completed, but not the hash one, the buffer was
being decrypted again, as the SUBMIT_JOB_AES_DEC was
called.
Instead, a NULL job should be returned instead,
so hash operation can start.

Change-Id: If663eddc88e454c14fa80f5506eb51046d0a2b83
@tkanteck
Copy link
Contributor

The patch fixes the reported issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkanteck @pablodelara