[xpu] [Windows] Do not reset %LIB% on Windows after building torch
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlGao4
changed the title
%LIB% on Windows after building torch%LIB% on Windows after building torch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm building ipex on Windows, I noticed that torchaudio, torchvision and ipex will fail after successfully building torch. After I removed the block building PyTorch and restart
cmd.exe, the rest was compiled successfully. I forgot to save the error message, but the main idea is that lib not found (like kernel32.lib).Then I noticed in
compile_bundle.batthatset "LIB="will actually delete this variable! Then the compiler won't find static libs in default VS lib paths, so kernel32.lib will not be found.