Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes related to selinux and permissions for openshift #970

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

mregmi
Copy link
Contributor

@mregmi mregmi commented Apr 18, 2022

  • run the sgx container as container_device_plugin_t and init container
    as container_device_plugin_init_t. these labels are being added to
    container_selinux package upstream.
  • add rbac role for openshift

Signed-off-by: Manish Regmi [email protected]

@mregmi mregmi requested review from rojkov, bart0sh and mythi as code owners April 18, 2022 16:29
@mregmi mregmi force-pushed the upstream_ready branch 2 times, most recently from 5a04f4d to c0b3162 Compare April 18, 2022 23:26
pkg/controllers/sgx/controller.go Outdated Show resolved Hide resolved
deployments/sgx_plugin/base/intel-sgx-plugin.yaml Outdated Show resolved Hide resolved
@mregmi mregmi force-pushed the upstream_ready branch 2 times, most recently from 8240e0b to 6b91b88 Compare April 27, 2022 23:12
@Walnux
Copy link

Walnux commented Apr 28, 2022

The new change looks good to me. :)

 * run the sgx container as container_device_plugin_t and init container
   as container_device_plugin_init_t. these labels are being added to
   container_selinux package upstream.
 * add rbac role for openshift
Signed-off-by: Manish Regmi <[email protected]>
@mregmi
Copy link
Contributor Author

mregmi commented Apr 29, 2022

@rojkov @bart0sh can we get review. thanks.

@mythi
Copy link
Contributor

mythi commented Apr 29, 2022

@rojkov @bart0sh can we get review. thanks.

+1 for merging

Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bart0sh bart0sh merged commit 9a78e44 into intel:main Apr 29, 2022
@mregmi mregmi deleted the upstream_ready branch May 3, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants