-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix builds with buildah #579
Conversation
@mythi Can you add an actual error to the description and commit message? It would help a lot to understand the fix. |
@bart0sh I'm still trying to comprehend the core issue. the new buildah (and dependencies) pushed on friday are broken. |
564cdb7
to
9bae104
Compare
@mythi This is ok as a quick workaround, but I'd prefer previous approach for a long term. It's more controllable and reproducible than relying on something that we can't change. |
OTOH, I'm expecting the runner version upgrades are better validated. What we get from the repo now is broken and we cannot rollback either because only one version is provided... :-) |
@mythi Can we have the same buildah version in Jenkins and the Github actions if we use buildah from the runner VM? |
runner virtual env VMs are Github specific. I can make Github Actions work with libcontainers repo but we still have the open why the images fail to build with buildah 1.19.4. I have submitted a buildah issue: containers/buildah#3008 |
efda50c
to
2d7a507
Compare
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
- Coverage 57.20% 57.06% -0.15%
==========================================
Files 31 31
Lines 2117 2117
==========================================
- Hits 1211 1208 -3
- Misses 837 839 +2
- Partials 69 70 +1
Continue to review full report at Codecov.
|
@mythi would it make sense to use buildah from official Ubuntu repositories https://packages.ubuntu.com/groovy/buildah ? |
buildah 1.19.4 install from the external repository adds a dependency to containers-common that comes with files that conflicts with the virtual env installation. remove the virtual env installation before proceeding with buildah install. Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
@bart0sh I should have this fixed now. It's still not clear why buildah fails... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Mikko Ylinen [email protected]