Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix builds with buildah #579

Merged
merged 2 commits into from
Feb 18, 2021
Merged

ci: fix builds with buildah #579

merged 2 commits into from
Feb 18, 2021

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Feb 15, 2021

Signed-off-by: Mikko Ylinen [email protected]

@bart0sh
Copy link
Member

bart0sh commented Feb 15, 2021

@mythi Can you add an actual error to the description and commit message? It would help a lot to understand the fix.

@mythi
Copy link
Contributor Author

mythi commented Feb 15, 2021

@bart0sh I'm still trying to comprehend the core issue. the new buildah (and dependencies) pushed on friday are broken.

@mythi mythi force-pushed the PR-2021-012 branch 2 times, most recently from 564cdb7 to 9bae104 Compare February 15, 2021 12:20
@mythi mythi changed the title ci: workaround broken buildah packaging ci: github: use buildah from the runner VM Feb 15, 2021
@mythi mythi marked this pull request as ready for review February 15, 2021 12:40
@mythi mythi requested review from bart0sh, kad and rojkov as code owners February 15, 2021 12:40
@mythi
Copy link
Contributor Author

mythi commented Feb 15, 2021

@bart0sh @rojkov this fixes Github CI, Jenkins is still broken (the latest buildah from the repo fails to build images). Do you think we could rely on tools Github runners provide and accept this as a hot-fix while I fix Jenkins?

/cc @kad

@bart0sh
Copy link
Member

bart0sh commented Feb 15, 2021

@mythi This is ok as a quick workaround, but I'd prefer previous approach for a long term. It's more controllable and reproducible than relying on something that we can't change.

@mythi
Copy link
Contributor Author

mythi commented Feb 15, 2021

It's more controllable and reproducible than relying on something that we can't change.

OTOH, I'm expecting the runner version upgrades are better validated. What we get from the repo now is broken and we cannot rollback either because only one version is provided... :-)

@bart0sh
Copy link
Member

bart0sh commented Feb 15, 2021

@mythi Can we have the same buildah version in Jenkins and the Github actions if we use buildah from the runner VM?
Would it make sense to use buildah from official Ubuntu repos for both GH actions and Jenkins environments?

@mythi
Copy link
Contributor Author

mythi commented Feb 15, 2021

Can we have the same buildah version in Jenkins and the Github actions if we use buildah from the runner VM?

runner virtual env VMs are Github specific. I can make Github Actions work with libcontainers repo but we still have the open why the images fail to build with buildah 1.19.4.

I have submitted a buildah issue: containers/buildah#3008

@mythi mythi force-pushed the PR-2021-012 branch 2 times, most recently from efda50c to 2d7a507 Compare February 15, 2021 20:00
@codecov-io
Copy link

Codecov Report

Merging #579 (2d7a507) into master (18b887b) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   57.20%   57.06%   -0.15%     
==========================================
  Files          31       31              
  Lines        2117     2117              
==========================================
- Hits         1211     1208       -3     
- Misses        837      839       +2     
- Partials       69       70       +1     
Impacted Files Coverage Δ
pkg/deviceplugin/server.go 84.17% <0.00%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b887b...2d7a507. Read the comment docs.

@mythi mythi changed the title ci: github: use buildah from the runner VM WIP: ci: fix builds with buildah Feb 15, 2021
@bart0sh
Copy link
Member

bart0sh commented Feb 16, 2021

@mythi would it make sense to use buildah from official Ubuntu repositories https://packages.ubuntu.com/groovy/buildah ?
This way we can ensure we're using the same buildah version in GH actions and Jenkins.

buildah 1.19.4 install from the external repository adds a
dependency to containers-common that comes with files that
conflicts with the virtual env installation.

remove the virtual env installation before proceeding with buildah
install.

Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
@mythi
Copy link
Contributor Author

mythi commented Feb 16, 2021

@bart0sh I should have this fixed now. It's still not clear why buildah fails...

@mythi mythi changed the title WIP: ci: fix builds with buildah ci: fix builds with buildah Feb 16, 2021
Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rojkov rojkov merged commit 1a522bb into intel:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants