This repository has been archived by the owner on May 11, 2024. It is now read-only.
Load tests #38
Merged
Load tests #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2019 14:43
beataszelag
reviewed
Feb 20, 2019
| response_length=response.ByteSize()) | ||
|
|
||
|
|
||
| class MyLocust(Locust): |
There was a problem hiding this comment.
could you change names started with My...? i.e. to LocustTaskSet, LocustTests, LocusClass etc
beataszelag
reviewed
Feb 20, 2019
|
|
||
| class MyTaskSet(TaskSet): | ||
| data_for_requests = [] | ||
| GRPC_ADDRESS = os.environ.get('GRPC_ADDRESS', "URL") |
There was a problem hiding this comment.
did you consider getting all these values from args, not from envs?
There was a problem hiding this comment.
I thought about it, but locust doesn't provide any custom arguments interface so i would have to write some workarounds.
locustio/locust#65
mzegla
reviewed
Feb 20, 2019
| ```` | ||
| GRPC_ADDRESS # address to grpc endpoint | ||
| MODEL_NAME = # model name; default value=resnet | ||
| TENSOR_NAME # input tensor name' default value=in |
There was a problem hiding this comment.
Suggested change
| TENSOR_NAME # input tensor name' default value=in | |
| TENSOR_NAME # input tensor name; default value=in |
| tf_contrib_util.make_tensor_proto(self.imgs, shape=(self.imgs.shape))) | ||
|
|
||
| def on_stop(self): | ||
| print("Tasks was stopped") |
There was a problem hiding this comment.
Suggested change
| print("Tasks was stopped") | |
| print("Tasks have been stopped") |
| A script was prepared to launch specific amount of locust instances, by passing integer to bash script. | ||
| Without passing any parameter script will launch Locust in distributed mode with 2 slaves. | ||
| If you want to perform as many RPS as possible we recommend to spawn 1 slave for 1 CPU core. | ||
| Also this script creates temporary file `pid_locust` which keep PID of processes launched by this script. |
There was a problem hiding this comment.
Suggested change
| Also this script creates temporary file `pid_locust` which keep PID of processes launched by this script. | |
| Also this script creates temporary file `pid_locust` which keeps PID of processes launched by this script. |
| ## Stop Locust | ||
|
|
||
| We run all instances as background process, so to stop load tests you can use our script ```./stop_locust``` | ||
| , which also remove temporary file created earlier or read PIDs in `pid_locust` file and simply kill processes listed in that file. |
There was a problem hiding this comment.
Suggested change
| , which also remove temporary file created earlier or read PIDs in `pid_locust` file and simply kill processes listed in that file. | |
| , which also removes temporary file created earlier or read PIDs in `pid_locust` file and simply kill processes listed in that file. |
|
|
||
|
|
||
| ## Description | ||
| Script available under this directory allow users to execute on their own load tests. Prepared [Locust class](image_locust.py) |
There was a problem hiding this comment.
Suggested change
| Script available under this directory allow users to execute on their own load tests. Prepared [Locust class](image_locust.py) | |
| Script available under this directory allows users to execute their own load tests. Prepared [Locust class](image_locust.py) |
|
|
||
| ## Description | ||
| Script available under this directory allow users to execute on their own load tests. Prepared [Locust class](image_locust.py) | ||
| on start loads environment variables and images also create grpc stub. In hatching phase this client only perform request to GRPC service using earlier loaded images. |
There was a problem hiding this comment.
Suggested change
| on start loads environment variables and images also create grpc stub. In hatching phase this client only perform request to GRPC service using earlier loaded images. | |
| loads configuration from environment variables and creates grpc stub in `on start` method. In hatching phase this client only performs requests to GRPC service using earlier loaded images. |
beataszelag
approved these changes
Feb 21, 2019
mzegla
approved these changes
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: