This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Add headers even if no profile detected #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes a profile can't be detected, but the renderer can make a good guess. For example, if a movie can't be detected, some renderers can show it if they have a range operation sent. This change adds the operation range and conversion headers. I have tested this with a Samsung LN37D550 TV.
|
Technically that used to violate DLNA certifications as those options must not be present without a profile. But I'm neither up to date on the current specs nor a maintainer. |
|
I'm not sure about the spec either. All I know is that I wasn't able to cast some video files to my TV until I made this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a profile can't be detected, but the renderer can make a good
guess. For example, if a movie can't be detected, some renderers can show
it if they have a range operation sent. This change adds the operation
range and conversion headers.
I have tested this with a Samsung LN37D550 TV.