This repository has been archived by the owner on Aug 25, 2024. It is now read-only.
Input validation using operations #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghinsa
changed the title
johnandersen777
approved these changes
Mar 14, 2020
dffml/df/memory.py
Outdated
| self.__inputs.remove(x) | ||
| break | ||
|
|
||
| def remove_unvalidated_inputs(self) -> List[Input]: |
There was a problem hiding this comment.
We probably want this to return a MemoryInputSet.
dffml/df/memory.py
Outdated
| parents=parents, | ||
| origin=(operation.instance_name, key), | ||
| ) | ||
| new_Input = Input( |
There was a problem hiding this comment.
Suggested change
| new_Input = Input( | |
| new_input = Input( |
dffml/df/memory.py
Outdated
| ) | ||
| new_Input.validated = set_valid |
There was a problem hiding this comment.
Suggested change
| new_Input.validated = set_valid | |
| new_input.validated = set_valid |
dffml/df/memory.py
Outdated
| ) | ||
| new_Input.validated = set_valid | ||
| inputs.append(new_Input) |
There was a problem hiding this comment.
Suggested change
| inputs.append(new_Input) | |
| inputs.append(new_input) |
|
Can you merge master and make those small changes. Thanks! |
done |
Signed-off-by: John Andersen <[email protected]>
johnandersen777
approved these changes
Mar 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #382