Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add conditional execution for SBOM workflow on the main repository. #3389

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

rudrakshkarpe
Copy link
Contributor

Fixes #3322

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #3389 (e61f042) into main (5d9e797) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
+ Coverage   80.67%   80.98%   +0.31%     
==========================================
  Files         750      750              
  Lines       11534    11534              
  Branches     1560     1560              
==========================================
+ Hits         9305     9341      +36     
+ Misses       1791     1761      -30     
+ Partials      438      432       -6     
Flag Coverage Δ
longtests 75.81% <ø> (-0.02%) ⬇️
win-longtests 78.97% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I'll fix the commit message issue reported by gitlint during merging, but if you want to get it right next time here's the convention we use: https://www.conventionalcommits.org/en/v1.0.0/

Basically it needs a prefix explaining what category the commit is in; this one changes only our a continuous integration (CI) config so it would be prefixed with "ci: "

@terriko terriko merged commit 2847879 into intel:main Oct 5, 2023
20 of 21 checks passed
@terriko
Copy link
Contributor

terriko commented Oct 5, 2023

(And I see now that your commit message was fine, so it was actually complaining about the PR title, which gitlint checks since that becomes the default squash commit message if a PR has more than one commit message to choose from.)

@rudrakshkarpe rudrakshkarpe changed the title Add conditional execution for SBOM workflow on the main repository ci: add conditional execution for SBOM workflow on the main repository. Oct 5, 2023
@rudrakshkarpe
Copy link
Contributor Author

(And I see now that your commit message was fine, so it was actually complaining about the PR title, which gitlint checks since that becomes the default squash commit message if a PR has more than one commit message to choose from.)

Ohh! Noted! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: don't generate sboms on forks
3 participants