Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : add missing docstrings to package_list_parser.py #3377 #3382

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Swarno-Coder
Copy link
Contributor

This PR fixing the ISSUE #3377

docs: add missing docstrings to package_list_parser.py

  • ✅Docstrings added to each of the functions of the file mentioned.

@Swarno-Coder
Copy link
Contributor Author

fixes #3377

@Swarno-Coder Swarno-Coder changed the title Fixing Issue #3377 Fixed #3377 : [📄DOCS]: add missing docstrings to package_list_parser.py Oct 4, 2023
@terriko
Copy link
Contributor

terriko commented Oct 4, 2023

Looks promising! I'm going to approve the tests tor run. You'll likely fail the gitlint check because your PR title doesn't conform to the commit message style guide we use https://www.conventionalcommits.org/en/v1.0.0/. I can fix that during merge if there's no other test fails, or you can edit your PR title for me while you're waiting for the tests to run!

@Swarno-Coder Swarno-Coder changed the title Fixed #3377 : [📄DOCS]: add missing docstrings to package_list_parser.py Fix : add missing docstrings to package_list_parser.py #3377 Oct 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3382 (debc9d2) into main (4f4ede0) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
+ Coverage   80.72%   80.93%   +0.20%     
==========================================
  Files         750      750              
  Lines       11534    11534              
  Branches     1560     1560              
==========================================
+ Hits         9311     9335      +24     
+ Misses       1786     1766      -20     
+ Partials      437      433       -4     
Flag Coverage Δ
longtests 75.81% <ø> (-0.02%) ⬇️
win-longtests 78.92% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/package_list_parser.py 38.84% <ø> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is ready to merge (I'll fix the gitlint complaint when I squash). Thanks @Swarno-Coder and congrats on your first commit with us. Happy hacktoberfest!

@terriko terriko merged commit 5d9e797 into intel:main Oct 4, 2023
@Swarno-Coder
Copy link
Contributor Author

@terriko Can you please add "hacktoberfest-accepted" label to get accepted this PR.

@Swarno-Coder
Copy link
Contributor Author

@terriko please add "hacktoberfest-accepted" badge. It's urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants