[VLM]fix bs and grad reset #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: n1ck-guo <[email protected]>
n1ck-guo
requested review from
wenhuach21 and
WeiweiZhang1
and removed request for
wenhuach21
wenhuach21
reviewed
Nov 27, 2024
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
approved these changes
Nov 27, 2024
wenhuach21
reviewed
Nov 27, 2024
wenhuach21
reviewed
Nov 27, 2024
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 27, 2024
auto_round/mllm/autoround_mllm.py
Outdated
| "reset to 1") | ||
| logger.warning( | ||
| f"batch_size({batch_size}) cannot be used for calibrating non-text modules, reset to 1" | ||
| f" and gradient_accumulate_steps reset to {batch_size * gradient_accumulate_steps}") |
There was a problem hiding this comment.
better follow this style,
reset bs to 1 and grad to xxx as bs=8 cannnot be used,
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 27, 2024
| f"rest batch_size({batch_size}) to 1 and " | ||
| f"gradient_accumulate_steps({gradient_accumulate_steps}) " | ||
| f"to {batch_size * gradient_accumulate_steps}, " | ||
| f"cause batch_size={batch_size} cannot be used for calibrating non-text modules.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.