vllm/llama-vision llava calibration infinite loop fix #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang, Weiwei1 <[email protected]>
Signed-off-by: Zhang, Weiwei1 <[email protected]>
wenhuach21
reviewed
Nov 25, 2024
wenhuach21
changed the title
wenhuach21
changed the title
wenhuach21
reviewed
Nov 25, 2024
wenhuach21
changed the title
wenhuach21
reviewed
Nov 25, 2024
wenhuach21
reviewed
Nov 25, 2024
|
remember to remind user to include this fix in the recipe of llama-vision |
Signed-off-by: Zhang, Weiwei1 <[email protected]>
Signed-off-by: Zhang, Weiwei1 <[email protected]>
wenhuach21
changed the title
wenhuach21
reviewed
Nov 26, 2024
Signed-off-by: n1ck-guo <[email protected]>
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 26, 2024
wenhuach21
reviewed
Nov 26, 2024
wenhuach21
changed the title
wenhuach21
reviewed
Nov 26, 2024
Signed-off-by: n1ck-guo <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 26, 2024
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 26, 2024
Signed-off-by: n1ck-guo <[email protected]>
Signed-off-by: n1ck-guo <[email protected]>
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Nov 26, 2024
| if quant_nontext_module and batch_size != 1: | ||
| logger.warning(f"batch_size({batch_size}) cannot be used for calibrating non-text modules," | ||
| "reset to 1") | ||
| batch_size = 1 |
There was a problem hiding this comment.
the gradient_accumualte should be changed too
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.