qwen2_bugfix, add adamround vision UT #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang, Weiwei1 <[email protected]>
wenhuach21
reviewed
Oct 16, 2024
| @@ -721,7 +720,7 @@ def forward(m, hidden_states, *positional_args, **kwargs): | |||
| else: | |||
| self.inputs[name][key] = list(torch.split(alibi.to("cpu"), 1, dim=0)) | |||
| elif "position_ids" in key or 'cache_position' in key: | |||
| if self.train_bs == 1 and self.not_share_rotary_pos_emb_flag: | |||
| if self.train_bs == 1 and self.not_share_position_ids_flag: | |||
There was a problem hiding this comment.
we could refine this later, we could add a shareable, contatable, etc for each key. In the future, we'd better not change the code in autoround.py but change the code in special_model_handle
wenhuach21
approved these changes
Oct 16, 2024
Signed-off-by: Zhang, Weiwei1 <[email protected]>
wenhuach21
approved these changes
Oct 16, 2024
Signed-off-by: Zhang, Weiwei1 <[email protected]>
XuehaoSun
approved these changes
Oct 16, 2024
XuehaoSun
pushed a commit
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Zhang, Weiwei1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.