Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torchserve 0.11.0 tests update #271

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

sharvil10
Copy link
Contributor

Description

This PR updates the tests and config for the torchserve version 0.11.0

Changes Made

  1. Disable token authentican in config.properties
  2. Enabled model_api in config.properties because the default behavior has been to set it to false.
  3. Fixed some tests by mounting the workflow store directories.
  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

Copy link
Contributor

@tylertitsworth tylertitsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other feature changes we need to highlight in the README or add a test for?

pytorch/serving/config.properties Show resolved Hide resolved
pytorch/serving/model-store/rest-test.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 1, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

tylertitsworth
tylertitsworth previously approved these changes Aug 1, 2024
@tylertitsworth tylertitsworth merged commit 41af29b into main Aug 1, 2024
6 checks passed
@tylertitsworth tylertitsworth deleted the sharvil/torchserve-0.11.1-token branch August 1, 2024 22:37
jitendra42 pushed a commit to jitendra42/ai-containers that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants