Test Reporter for Container CI #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s changes applies to the new repository format
cholocate
requested review from
tylertitsworth,
jitendra42,
sramakintel and
sharvil10
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files.github/workflows/integration-test.yaml |
tylertitsworth
added
WIP
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
tylertitsworth
changed the title
…in test-runners *added recreate input
…mment *Also removed validation jobs
Comment on lines
91
to
95
| - name: Display structure of downloaded files | ||
| run: | | ||
| ls . | ||
| cat combined.json | ||
| cat output.txt |
There was a problem hiding this comment.
Can be removed assuming you are done debugging
test-runner/test_runner.py
Outdated
| ) | ||
| json_summary_path = f"test-runner-summary-{unique_identifier}.json" | ||
|
|
||
| with open(json_summary_path, "w") as file: |
There was a problem hiding this comment.
Suggested change
| with open(json_summary_path, "w") as file: | |
| with open(json_summary_path, "w", encoding="utf-8") as file: |
This will fix your lint error.
… written and not picked up by upload-artifacts
…runner-summary*.json
|
|
Resolved case where Challenges and notes to self:Make sure to always use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following changes in the
.yamlfiles worked with the previous forked repository, and will likely require some additional changes as we migrate to the new ai-containers format.Changes Made
upload-artifactactions inaction.ymlto storetest-runner logspersistently across each matrix element that was picked up ingroup-diffmerge-logsaction to download artifacts after thetest-runnercompleted and usesjqto produce combined JSON file with all tests and its status, then transfer result tooutput.txtValidation