Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apptainer build functionality for python #211

Merged
merged 76 commits into from
Jul 11, 2024
Merged

add apptainer build functionality for python #211

merged 76 commits into from
Jul 11, 2024

Conversation

sramakintel
Copy link
Contributor

@sramakintel sramakintel commented Jul 3, 2024 •
edited
Loading

Description

Related Issue

Changes Made

  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/apptainer-ci.yaml

PackageVersionLicenseIssue Type
intel/ai-containers/apptainermainNullUnknown License

apptainer/python/requirements.txt

PackageVersionLicenseIssue Type
intel-openmp2024.2.0NullUnknown License
mkl-include2024.2.0NullUnknown License
mkl2024.2.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 4.*.* 🟢 7.5
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1018 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies🟢 4dependency not pinned by hash detected -- score normalized to 4
Security-Policy🟢 9security policy file detected
Packaging🟢 10packaging workflow detected
SAST🟢 10SAST tool is run on all commits
Vulnerabilities🟢 91 existing vulnerabilities detected
actions/eWaterCycle/setup-apptainer 2.0.0 🟢 4.9
Details
CheckScoreReason
Maintained🟢 1016 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Code-Review⚠️ 2Found 1/4 approved changesets -- score normalized to 2
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
SAST🟢 7SAST tool detected but not run on all commits
Vulnerabilities🟢 91 existing vulnerabilities detected
actions/intel/ai-containers/apptainer main 🟢 8.2
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 925 out of 26 merged PRs checked by a CI test -- score normalized to 9
CII-Best-Practices🟢 5badge detected: Passing
Code-Review🟢 7Found 15/21 approved changesets -- score normalized to 7
Contributors🟢 10project has 15 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies⚠️ 2dependency not pinned by hash detected -- score normalized to 2
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 73 existing vulnerabilities detected
pip/intel-openmp 2024.2.0 UnknownUnknown
pip/mkl 2024.2.0 UnknownUnknown
pip/mkl-include 2024.2.0 UnknownUnknown
pip/numpy 1.26.4 🟢 8.4
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 1016 out of 16 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 10project has 95 contributing companies or organizations
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 9license file detected
Maintained🟢 1030 commit(s) and 26 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
SAST🟢 9SAST tool detected but not run on all commits
Security-Policy🟢 9security policy file detected
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 100 existing vulnerabilities detected
pip/psutil 6.0.0 🟢 5.8
Details
CheckScoreReason
Code-Review⚠️ 2Found 8/30 approved changesets -- score normalized to 2
Maintained🟢 1020 commit(s) and 14 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing🟢 10project is fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
pip/setuptools 69.5.1 🟢 6.3
Details
CheckScoreReason
Code-Review🟢 7Found 10/14 approved changesets -- score normalized to 7
Maintained🟢 1030 commit(s) and 9 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Packaging⚠️ -1packaging workflow not detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Binary-Artifacts⚠️ 0binaries present in source code
Vulnerabilities🟢 100 existing vulnerabilities detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing🟢 10project is fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Manifest Files

.github/workflows/apptainer-ci.yaml
apptainer/python/requirements.txt

@sramakintel sramakintel mentioned this pull request Jul 3, 2024
Closed
4 tasks
@sramakintel sramakintel force-pushed the sramakr1/apptainer_python branch 2 times, most recently from 2406d80 to be0e866 Compare July 3, 2024 16:31
@tylertitsworth tylertitsworth added github_actions Pull requests that update GitHub Actions code WIP Work in Progress labels Jul 3, 2024
@sramakintel sramakintel force-pushed the sramakr1/apptainer_python branch from 66b0750 to 8a60e26 Compare July 8, 2024 15:46
sramakintel added 19 commits July 8, 2024 13:47
@sramakintel
add apptainer build
0cf7451 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
correct apptainer uses
736b885 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add branch rule
e6803a5 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
remove null
df04e4e 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add intel
3e3905a 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
remove unused fields
013a67a 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add full branch
ac6d094 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
correct indents
3e6617f 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add triggers
9456806 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
correct triggers
e0f47eb 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
move apptainer file to workflows
496b0d6 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
change vars
066f47d 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
change registry
44f6717 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
change registry string
e84358f 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
remove on push
b6445cb 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
comment trigger
fbbdd44 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
revert changes
2e5342c 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add env
efb5b61 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
bump up apptainer version
ec7eac8 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
sramakintel and others added 17 commits July 9, 2024 08:41
@sramakintel
Merge branch 'main' into sramakr1/apptainer_python
5036278
@sramakintel
all pull request null
6779332 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
make change to def file to initate trigger
70fafe3 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
replace sha w/ branch name
e89b15a 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
track only yaml
5356d01 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
replicate local on CI
6d29df8 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
validate local
ebb2653 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
rever to sha
f3d7584 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
change trigger
8340694 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add fetch depth
8d2f128 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
18d25ac
@sramakintel
remove typo
300651e 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
add readme
03fbbf6 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0bd0342
@sramakintel
Merge branch 'main' into sramakr1/apptainer_python
a022ad1
@sramakintel
add build arg
956d763 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@sramakintel
update requirements.txt
030391c 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
tylertitsworth
tylertitsworth suggested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@tylertitsworth tylertitsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed README.md

apptainer/README.md Outdated Show resolved Hide resolved
apptainer/README.md Outdated Show resolved Hide resolved
apptainer/README.md Show resolved Hide resolved
tylertitsworth
tylertitsworth suggested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@tylertitsworth tylertitsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this requirements.txt to .github/dependabot.yml?

@sramakintel
update dependabot
ac7e823 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
tylertitsworth
tylertitsworth previously approved these changes Jul 11, 2024
View reviewed changes
@tylertitsworth tylertitsworth enabled auto-merge (squash) July 11, 2024 19:18
@tylertitsworth tylertitsworth disabled auto-merge July 11, 2024 19:20
@sramakintel
change branch to main
8d3dc16 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
@tylertitsworth tylertitsworth merged commit 608ea1f into main Jul 11, 2024
5 of 6 checks passed
@tylertitsworth tylertitsworth deleted the sramakr1/apptainer_python branch July 11, 2024 19:22
dmsuehir pushed a commit that referenced this pull request Jul 12, 2024
@sramakintel @pre-commit-ci
@dependabot @sharvil10 @dmsuehir
add apptainer build functionality for python (#211)
520fc0b 
Signed-off-by: Srikanth Ramakrishna <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: Tyler Titsworth <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Tyler Titsworth <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sharvil Shah <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylertitsworth tylertitsworth tylertitsworth left review comments

@sharvil10 sharvil10 Awaiting requested review from sharvil10 sharvil10 is a code owner

@jitendra42 jitendra42 Awaiting requested review from jitendra42 jitendra42 is a code owner

@dmsuehir dmsuehir Awaiting requested review from dmsuehir

@ma-pineda ma-pineda Awaiting requested review from ma-pineda

@jafraustro jafraustro Awaiting requested review from jafraustro

Assignees

@sramakintel sramakintel

Labels
github_actions Pull requests that update GitHub Actions code WIP Work in Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sramakintel @tylertitsworth @sharvil10